From: Fengguang Wu <fengguang.wu@intel.com>
To: David Miller <davem@davemloft.net>
Cc: ben@decadent.org.uk, kernel-janitors@vger.kernel.org,
linux-can@vger.kernel.org
Subject: Re: [can:master 118/170] ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined!
Date: Sat, 22 Sep 2012 08:24:26 +0800 [thread overview]
Message-ID: <20120922002426.GB5959@localhost> (raw)
In-Reply-To: <20120921.122418.1595502576924307596.davem@davemloft.net>
On Fri, Sep 21, 2012 at 12:24:18PM -0400, David Miller wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> Date: Fri, 21 Sep 2012 19:27:40 +0800
>
> > Hi Ben,
> >
> > FYI, kernel build failed on
> >
> > tree: git://gitorious.org/linux-can/linux-can-next master
> > head: 029d8ada9150a1177f09148284b5cd27a30d4db7
> > commit: 025e36332573177ecd7c12730e18a4390f994f05 [118/170] llc2: Remove dead code for state machine
> > config: x86_64-allmodconfig
> >
> > All related error/warning messages:
> >
> > ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined!
>
> The very next commit, written by me, after Ben's fixes this build
> error.
OK..
> It wasn't added by the CAN tree so bugging them is very inappropriate,
> the change came from the net-next tree.
Yup, I got an idea to fix it! :)
The root cause is the CAN tree get tested before the net-next tree
that it bases on, and I'm CCing the CAN list because it "seems" to be
testing the CAN tree.
The fix is to
a) Test the trees as soon as they are published, which will naturally
result in upstream trees being tested first. Currently some of the
build threads are overloaded, which leads to out-of-order testing
and some missed tests.
b) Use the pair (committer, git tree) to find the related mailing list.
The git tree alone is not reliable information, because one tree
can pull from the others, in which case the committer is actually
more reliable than the git url.
Thanks,
Fengguang
prev parent reply other threads:[~2012-09-22 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-21 11:27 [can:master 118/170] ERROR: "sysctl_llc_station_ack_timeout" [net/llc/llc2.ko] undefined! Fengguang Wu
2012-09-21 16:24 ` David Miller
2012-09-22 0:24 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922002426.GB5959@localhost \
--to=fengguang.wu@intel.com \
--cc=ben@decadent.org.uk \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).