From: Fabio Baltieri <fabio.baltieri@gmail.com>
To: "\"Bernd Krumböck\"" <krumboeck@universalnet.at>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org, Kurt Van Dijck <kurt.van.dijck@eia.be>,
Wolfgang Grandegger <wg@grandegger.com>,
Oliver Hartkopp <socketcan@hartkopp.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/9] can: add tx/rx LED trigger support
Date: Mon, 17 Dec 2012 22:42:23 +0100 [thread overview]
Message-ID: <20121217214222.GA3539@balto.lan> (raw)
In-Reply-To: <86fd45485e2016d2c5ad27f28669195e.squirrel@webmail.universalnet.at>
On Mon, Dec 17, 2012 at 09:20:57PM +0100, "Bernd Krumböck" wrote:
> > If you think it's useful for USB controller, just tell me or modify the
> > driver by yourself! As you see the patch is really easy.
>
> At least it is useful for the usb_8dev driver. I'll write a patch.
>
> Photo of the device:
> http://www.8devices.com/product/2/usb2can
Sure that it's needed? That status LED is probably controlled directly
by the firmware itself. Anyway I think it makes sense to support all
the mainline drivers and I'm really happy if you test the patch on
your hardware!
My only suggestion is to keep the LED support on a separate patch from
the "add driver" one.
Cheers,
Fabio
--
Fabio Baltieri
next prev parent reply other threads:[~2012-12-17 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-16 11:08 [PATCH 0/9] tx/rx LED trigger support Fabio Baltieri
2012-12-16 11:08 ` [PATCH 1/9] can: add " Fabio Baltieri
2012-12-17 7:28 ` Bernd Krumboeck
2012-12-17 9:34 ` Kurt Van Dijck
2012-12-17 17:41 ` Fabio Baltieri
2012-12-17 20:20 ` "Bernd Krumböck"
2012-12-17 21:42 ` Fabio Baltieri [this message]
2012-12-18 6:02 ` "Bernd Krumböck"
2012-12-16 11:08 ` [PATCH 2/9] can: flexcan: add " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 3/9] can: at91_can: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 4/9] can: ti_hecc: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 5/9] can: c_can: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 6/9] can: mcp251x: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 7/9] can: sja1000: " Fabio Baltieri
2012-12-16 11:08 ` [PATCH 8/9] can: export a safe netdev_priv wrapper for candev Fabio Baltieri
2012-12-16 11:08 ` [PATCH 9/9] can: rename LED trigger name on netdev renames Fabio Baltieri
2012-12-16 22:37 ` [PATCH 0/9] tx/rx LED trigger support Marc Kleine-Budde
2012-12-16 22:51 ` Fabio Baltieri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121217214222.GA3539@balto.lan \
--to=fabio.baltieri@gmail.com \
--cc=krumboeck@universalnet.at \
--cc=kurt.van.dijck@eia.be \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).