Re: [PATCH can-utils] Don't overwrite PREFIX and DESTDIR when provided via the environment

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

On Sun, Aug 18, 2013 at 01:02:29PM +0200, Oliver Hartkopp wrote:
> On 17.08.2013 21:32, Marc Kleine-Budde wrote:
> > On 08/17/2013 09:28 PM, Uwe Kleine-König wrote:
> >> For creating a Debian package providing PREFIX and DESTDIR via the
> >> environment is the easiest option. So use ?= to assign these two
> >> variables to honor the values in the environment.
> > 
> > I suggest to use autotools.
> > 
> > ./configure && make && make install
> > 
> 
> Today i like the possibility to use autotools or just to say 'make && make
> install' without autotools.
> 
> You may choose for the Debian package the build process which is more appropriate.
> 
> >
> > -DESTDIR =
> > -PREFIX = /usr/local
> > +DESTDIR ?=
> > +PREFIX ?= /usr/local
> >
> 
> 1. good idea - I already pushed it to the git tree
Thanks, but you somehow messed up the attribution. All three patches I
sent in the last few days appear with author=you :-(

> 2. I wonder if we should doublecheck the target directories when making it a
> real Debian package
> 
> e.g. the majority of tools should go into /usr/bin then
> 
> But some tools that require root rights should go to /usr/sbin like cangw,
> isotptun, slcan_attach, slcand
I don't feel qualified to judge that. The File Heirarchy Standard says
(http://www.pathname.com/fhs/pub/fhs-2.3.html#PURPOSE16):

	Utilities used for system administration (and other root-only
	commands) are stored in /sbin, /usr/sbin, and /usr/local/sbin.
	/sbin contains binaries essential for booting, restoring,
	recovering, and/or repairing the system in addition to the
	binaries in /bin.


> Or should they stay in /usr/bin and lead to an error when the admin rights are
> not granted??
Even if they are in /usr/sbin they should lead to an error in that case.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |