Re: [PATCH] can: add explicit copyright to header can/netlink.h

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

Hello Wolfgang,

On Fri, Sep 06, 2013 at 10:35:54PM +0200, Wolfgang Grandegger wrote:
> On Fri, 6 Sep 2013 21:37:44 +0200, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > Hello Wolfgang,
> > 
> > On Fri, Sep 06, 2013 at 05:48:06PM +0200, Wolfgang Grandegger wrote:
> >> Hi Marc and Uwe,
> >> 
> >> On Fri,  6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde
> >> <mkl@pengutronix.de>
> >> wrote:
> >> > From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> > 
> >> > This file is copied to the source code of user space applications (in
> >> > this case can-utils) and so it makes sense to mention explicitly its
> >> > copyright. I added the terms of C code that was introduced in the
> same
> >> > commit as this header.
> >> > 
> >> > Cc: Wolfgang Grandegger <wg@grandegger.com>
> >> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >> > ---
> >> > Hello Wolfgang,
> >> > 
> >> > this is the remaining hunk from Uwe's patch that has not been Acked.
> >> > Continuing
> >> > with Uwe's words (adopted):
> >> > 
> >> > I think it is necessary to get the Ack of the people mentioned in
> >> > the Cc: commit footers. @Wolfgang: I added a statement
> >> > 
> >> >     The provided data structures and external interfaces from this
> code
> >> >     are not restricted to be used by software with a GPL compatible
> >> >     license.
> >> > 
> 
> >> > similar to the other can headers. Does that suit you?
> 
> >> 
> 
> >> Is this the common phrase other public header files use as well?
> 
> >> What's the motivation for that addition. Likely I might
> 
> >> have missed some related discussion. 
> 
> > This is what the headers by Volkswagen are using, but it's only a
> 
> > suggestion. So it's up to you.
> 
> 
> 
> Which headers. In net-next's "include/uapi/linux/can.h" I read:
> 
> 
> 
> /*
>  * linux/can.h
>  *
>  * Definitions for CAN network layer (socket addr / CAN frame / CAN filter)
>  *
>  * Authors: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>
>  *          Urs Thuermann   <urs.thuermann@volkswagen.de>
>  * Copyright (c) 2002-2007 Volkswagen Group Electronic Research
>  * All rights reserved.
>  *
>  */
Yeah, in net-next the license is still missing, see
http://thread.gmane.org/gmane.linux.can/3757 for my suggestion. The
sentence is taken from the corresponding .c files.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |