From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] can: add explicit copyright to header can/netlink.h Date: Fri, 6 Sep 2013 22:45:03 +0200 Message-ID: <20130906204503.GW24802@pengutronix.de> References: <1378477811-3606-1-git-send-email-mkl@pengutronix.de> <20130906193744.GV24802@pengutronix.de> <62dc5723044ed5670932d4a452471510@grandegger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:34222 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966Ab3IFUpJ (ORCPT ); Fri, 6 Sep 2013 16:45:09 -0400 Content-Disposition: inline In-Reply-To: <62dc5723044ed5670932d4a452471510@grandegger.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Wolfgang Grandegger Cc: Marc Kleine-Budde , linux-can@vger.kernel.org, kernel@pengutronix.de Hello Wolfgang, On Fri, Sep 06, 2013 at 10:35:54PM +0200, Wolfgang Grandegger wrote: > On Fri, 6 Sep 2013 21:37:44 +0200, Uwe Kleine-K=F6nig > wrote: > > Hello Wolfgang, > >=20 > > On Fri, Sep 06, 2013 at 05:48:06PM +0200, Wolfgang Grandegger wrote= : > >> Hi Marc and Uwe, > >>=20 > >> On Fri, 6 Sep 2013 16:30:11 +0200, Marc Kleine-Budde > >> > >> wrote: > >> > From: Uwe Kleine-K=F6nig > >> >=20 > >> > This file is copied to the source code of user space application= s (in > >> > this case can-utils) and so it makes sense to mention explicitly= its > >> > copyright. I added the terms of C code that was introduced in th= e > same > >> > commit as this header. > >> >=20 > >> > Cc: Wolfgang Grandegger > >> > Signed-off-by: Uwe Kleine-K=F6nig > >> > Signed-off-by: Marc Kleine-Budde > >> > --- > >> > Hello Wolfgang, > >> >=20 > >> > this is the remaining hunk from Uwe's patch that has not been Ac= ked. > >> > Continuing > >> > with Uwe's words (adopted): > >> >=20 > >> > I think it is necessary to get the Ack of the people mentioned i= n > >> > the Cc: commit footers. @Wolfgang: I added a statement > >> >=20 > >> > The provided data structures and external interfaces from th= is > code > >> > are not restricted to be used by software with a GPL compati= ble > >> > license. > >> >=20 >=20 > >> > similar to the other can headers. Does that suit you? >=20 > >>=20 >=20 > >> Is this the common phrase other public header files use as well? >=20 > >> What's the motivation for that addition. Likely I might >=20 > >> have missed some related discussion.=20 >=20 > > This is what the headers by Volkswagen are using, but it's only a >=20 > > suggestion. So it's up to you. >=20 >=20 >=20 > Which headers. In net-next's "include/uapi/linux/can.h" I read: >=20 >=20 >=20 > /* > * linux/can.h > * > * Definitions for CAN network layer (socket addr / CAN frame / CAN f= ilter) > * > * Authors: Oliver Hartkopp > * Urs Thuermann > * Copyright (c) 2002-2007 Volkswagen Group Electronic Research > * All rights reserved. > * > */ Yeah, in net-next the license is still missing, see http://thread.gmane.org/gmane.linux.can/3757 for my suggestion. The sentence is taken from the corresponding .c files. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= |