Re: [PATCH v5 5/5] include: Move includes copied from the Linux kernel into include/linux

["Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>]

On Fri, Jan 17, 2014 at 03:04:53PM +0100, Marc Kleine-Budde wrote:
> On 01/17/2014 02:37 PM, Uwe Kleine-König wrote:
> > Hallo Marc,
> > 
> > On Thu, Jan 16, 2014 at 11:11:28PM +0100, Marc Kleine-Budde wrote:
> >> On 01/16/2014 08:28 PM, Uwe Kleine-König wrote:
> >>> On Thu, Jan 16, 2014 at 05:12:34PM +0100, Marc Kleine-Budde wrote:
> >>>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >>>>
> >>>> This makes it possible to update the copies more easily, e.g.:
> >>>>
> >>>> 	cd $path_to_linux_repo
> >>>> 	make headers_install
> >>>> 	rsync -a --delete --exclude .\* usr/include/linux/can* $path_to_can_utils/include/linux
> >>>>
> >>>> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
> >>>> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >>
> >>> I want to have pointed out in the commit log that it was you who added
> >>> isotp.h to the move. I don't care that much for your split into two
> >>> patches to fix the #includes first, but IMHO that should be documented,
> >>> too.
> >>
> >> Yes, but no. I imported the isotp header, but not from the kernel. It
> >> was imported from the berlios svn repo.
> 
> > I didn't mean isotp when it was added to can-utils, but compared to my
> > patch "include: Move includes copied from the Linux kernel into
> > include/linux" you also moved isotp.h from socketcan/can to linux/can in
> > can-utils. That's what I thought you should point out. That this change
> > makes the changelog wrong is another issue.
> 
> Then I'll change the commit message to "move all headers from
> socketcan/can to linux/can".
and please also add something like:

	[mkl: also move isotp.h although Uwe skipped it as it is not
	part of the upstream kernel; adapt commit log accordingly]

> > Where can this external kernel module be found? IMHO it would be worth
> > to point to its (hopefully) git repository in isotp{*.c,.h}.
> 
> https://gitorious.org/linux-can/can-modules
Is it a possibility to merge can-modules and can-utils? Then there would
only a single instance of isotp.h be needed. IIUC the source of isotp.h
is in can-modules. If so, adding a license to it should be done in
can-modules, too.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |