Linux CAN drivers development
 help / color / mirror / Atom feed
From: Alexander GQ Gerasiov <gq@cs.msu.su>
To: linux-can@vger.kernel.org
Subject: Re: SJA1000 loopback feature
Date: Thu, 19 Jun 2014 16:44:24 +0400	[thread overview]
Message-ID: <20140619164424.244e5634@snail> (raw)
In-Reply-To: <53A1EDA7.7040504@hartkopp.net>

Hello, Oliver.

Wed, 18 Jun 2014 21:51:03 +0200
Oliver Hartkopp <socketcan@hartkopp.net> wrote:

> > So we want to be able to tune CAN subsystem to ignore ACK absence.
> > As we understand, SJA1000 has the mode we are looking for (but lacks
> > support in driver/subsystem).
> 
> If we would find a name for it, it could be:
> 
> #define CAN_CTRLMODE_PRESUME_ACK        0x40    /* ignore missing CAN
> ACKs */

Ok, what is the right git repository for linux-can kernel modules?
I can see
linux-can/can-modules
linux-can/linux-can
linux-can/linux-can-next

or may be there is any tree on git.kernel.org?

Where are the actual sources we need to patch?

> > As LOOPBACK option for interface means that TX should be passed to
> > RX, thats not exactly what we need. (As for loopback we already
> > have it on the socket with CAN_RAW_LOOPBACK and
> > CAN_RAW_RECV_OWN_MSGS.) I think we could add one more interface
> > mode "ignore-no-ack", but we'd like to stay as much closer to
> > vanilla kernel as possible and contribute our modifications, so we
> > need your opinion on
> > 
> > Is this the common situation? Do you interested in such mode and our
> > modifications? How should we realize thees modifications?
> > 
> 
> Just to give an example how I dealed with such situation:
> 
> 1. Let all applications run on a virtual CAN interface (e.g. vcan0).
> 2. make a cross routing with can-gw netlink routes

Yes, I was thinking about it. We strictly need the same order of
events on both buses (local/virtual and remote/hardware), but in case of
bridging (userspace, or even in-kernel one) race is possible. So we'd
better use one bus (to rule them all =)) 

-- 
Alexander.

  reply	other threads:[~2014-06-19 12:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-16 16:20 SJA1000 loopback feature Nikita Edward Baruzdin
2014-06-16 18:56 ` Oliver Hartkopp
2014-06-17 11:41   ` Nikita Edward Baruzdin
2014-06-17 12:13     ` Alexander GQ Gerasiov
2014-06-18 19:51       ` Oliver Hartkopp
2014-06-19 12:44         ` Alexander GQ Gerasiov [this message]
2014-06-19 14:55           ` Oliver Hartkopp
2014-06-19 16:01             ` Alexander GQ Gerasiov
2014-06-19 17:43               ` Oliver Hartkopp
2014-06-19 18:07                 ` Alexander GQ Gerasiov
2014-06-19 20:32                   ` vcan to can0 bridging Kurt Van Dijck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140619164424.244e5634@snail \
    --to=gq@cs.msu.su \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox