linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Matthias Klein <matthias.klein@optimeas.de>
Cc: wg@grandegger.com, mkl@pengutronix.de, linux-can@vger.kernel.org,
	support@karo-electronics.de
Subject: Re: can: flexcan: problems with bus error reporting om i.MX53
Date: Fri, 25 Jul 2014 21:04:25 +0200	[thread overview]
Message-ID: <20140725190425.GC24839@linutronix.de> (raw)
In-Reply-To: <53D29F02.8010708@optimeas.de>

* Matthias Klein | 2014-07-25 20:16:34 [+0200]:

>Hi all,
>
>we had the following problems when we enabled bus error reporting on
>an i.MX537 (Ka-Ro TX53-8130):
>- interrupt flooding when sending a packet on an open bus

This happens because
#1 the ISR always returns that it handled the interrupt even if it did
   nothing
#2 on error the interrupt source remains asserted on an open CAN bus as
   long as the CAN bus is open. This was verified on iMX53 (which has
   FLEXCAN_HAS_BROKEN_ERR_STATE) and imx6q

>- bus state change notifications did not work properly
The error-passive -> error warning transition was not reported to
userland, #3

>- second bus state change after bus recovery was not properly notified
The second transition from error-passive to error-warning does not work
properly. By second is meant a transition while the error counter >0
(in test scenarion  120 < x < 128). After the BUS was closed, the CAN
controller was able to send packages (they were received) but the
internal state said passive mode and the error counter was >128 and
decrementing with each can message sent.
New #4.

>Best regards,
>Matthias Klein

Sebastian

  reply	other threads:[~2014-07-25 19:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 18:16 can: flexcan: problems with bus error reporting om i.MX53 Matthias Klein
2014-07-25 19:04 ` Sebastian Andrzej Siewior [this message]
2014-07-28  6:34 ` Matthias Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140725190425.GC24839@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=linux-can@vger.kernel.org \
    --cc=matthias.klein@optimeas.de \
    --cc=mkl@pengutronix.de \
    --cc=support@karo-electronics.de \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).