Re: [PATCH v2] can/peak_usb: add support for PEAK new CANFD USB adapters

[Jeremiah Mahler <jmmahler@gmail.com>]

Stephane,

On Mon, Dec 08, 2014 at 12:36:12PM +0100, Stephane Grosjean wrote:
> Add support for the following new PEAK-System technik CANFD USB adapters:
> 
> PCAN-USB FD             single CANFD channel USB adapter
> PCAN-USB Pro FD         dual CANFD channels USB adapter
> 
> Signed-off-by: Stephane Grosjean <s.grosjean@peak-system.com>
> ---
> v2: removes 2 changes that have been erroneously included in
>     peak_usb_create_dev() (-netdev->dev_id = ctrl_idx;) as well as in
>     peak_usb_probe() (move of "const u16 usb_id_product" declaration) in the
>     previous version of this patch.
> 
>  drivers/net/can/usb/Kconfig                  |   14 +-
[...]
> +};
> +
> +#define PCAN_UFD_MSG_OVERRUN		0x101
> +
> +#define PCAN_UFD_OVMSG_CHANNEL(o)	((o)->channel & 0xf)
> +
> +struct __packed pcan_ufd_ovr_msg {
> +	__le16	size;
> +	__le16	type;
> +	__le32	ts_low;
> +	__le32	ts_high;
> +	u8	channel;
> +	u8	unused[3];
> +};
> +
> +/* Clock mode frequence values */
                 ^^^^^^^^^
				 frequency

> +static const u32 pcan_usb_fd_clk_freq[6] = {
> +	[PCAN_UFD_CLK_80MHZ] = 80000000,
> +	[PCAN_UFD_CLK_60MHZ] = 60000000,
> +	[PCAN_UFD_CLK_40MHZ] = 40000000,
> +	[PCAN_UFD_CLK_30MHZ] = 30000000,
> +	[PCAN_UFD_CLK_24MHZ] = 24000000,
> +	[PCAN_UFD_CLK_20MHZ] = 20000000
> +};
> +
> +/* build the opcode_channel field wth respect to the correct endianess */
                                     ^^^
									 with

> +static inline __le16 pucan_cmd_opcode_channel(int opcode, int channel)
> +{
> +	return cpu_to_le16(PUCAN_CMD_OPCODE_CHANNEL(opcode, channel));
> +}
> +
> +/* return a device USB interface */
> +static inline
> +struct pcan_usb_fd_if *pcan_usb_fd_dev_if(struct peak_usb_device *dev)
> +{
> +	struct pcan_usb_fd_device *pdev =
> +			container_of(dev, struct pcan_usb_fd_device, dev);
> +	return pdev->usb_if;
> +}
[...]

-- 
- Jeremiah Mahler