Re: [PATCH v6 5/7] can: kvaser_usb: Update interface state before exiting on OOM

Andri Yngvason
2015-01-26T10:53:02Z

Quoting Marc Kleine-Budde (2015-01-26 10:50:12)
> On 01/26/2015 11:28 AM, Andri Yngvason wrote:
> > Quoting Ahmed S. Darwish (2015-01-26 05:27:19)
> >> From: Ahmed S. Darwish <ahmed.darwish@valeo.com>
> >>
> >> Update all of the can interface's state and error counters before
> >> trying any skb allocation that can actually fail with -ENOMEM.
> >>
> >> Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >> Signed-off-by: Ahmed S. Darwish <ahmed.darwish@valeo.com>
> >> ---
> >> drivers/net/can/usb/kvaser_usb.c | 181 ++++++++++++++++++++++----------------
> >> 1 files changed, 105 insertions(+), 76 deletions(-)
> [..]
>
> > Looks good to me.
>
> Can I add your Acked-by to 5-7?
>
Yes.

--
Andri