From: Andri Yngvason <andri.yngvason@marel.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>, linux-can@vger.kernel.org
Cc: wg@grandegger.com
Subject: Re: [PATCH v6] can: move can_stats.bus_off++ from can_bus_off into can_change_state
Date: Wed, 7 Jan 2015 16:36:53 +0000 [thread overview]
Message-ID: <20150107163653.12684.92317@shannon> (raw)
In-Reply-To: <54AD4F82.6030207@pengutronix.de>
Quoting Marc Kleine-Budde (2015-01-07 15:23:46)
> On 12/11/2014 03:15 PM, Andri Yngvason wrote:
> > In order to be able to move the stats increment from can_bus_off() into
> > can_change_state(), the increment had to be moved back into code that was using
> > can_bus_off() but not can_change_state().
> >
> > As a side-effect, this patch fixes the following bugs:
> > * Redundant call to can_bus_off() in c_can.
> > * Bus-off counted twice in xilinx_can.
>
> FTBFS:
>
> > drivers/net/can/bfin_can.c: In function 'bfin_can_err':
> > drivers/net/can/bfin_can.c:355:8: error: 'struct net_device_stats' has no member named 'bus_off'
>
Whoops, sorry. I'll fix that ASAP.
--
Andri
prev parent reply other threads:[~2015-01-07 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 14:15 [PATCH v6] can: move can_stats.bus_off++ from can_bus_off into can_change_state Andri Yngvason
2014-12-12 13:00 ` Wolfgang Grandegger
2015-01-07 15:23 ` Marc Kleine-Budde
2015-01-07 16:36 ` Andri Yngvason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107163653.12684.92317@shannon \
--to=andri.yngvason@marel.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).