From: Mark Brown <broonie@kernel.org>
To: Roger Quadros <rogerq@ti.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>,
mkl@pengutronix.de, linux-can@vger.kernel.org, wsa@the-dreams.de,
kernel@pengutronix.de, linux-omap@vger.kernel.org
Subject: Re: [PATCH] can: c_can: use regmap_update_bits() to modify RAMINIT register
Date: Mon, 12 Jan 2015 12:05:41 +0000 [thread overview]
Message-ID: <20150112120541.GD4160@sirena.org.uk> (raw)
In-Reply-To: <54B39BAD.4070604@ti.com>
[-- Attachment #1: Type: text/plain, Size: 822 bytes --]
On Mon, Jan 12, 2015 at 12:02:21PM +0200, Roger Quadros wrote:
> +Mark with correct id.
Please fix your mail client to word wrap within paragraphs, it amkes
your mail more legible.
> > The problem here is we can't use regmap_update_bits() because we need to write a 1 to the DONE bit to clear it and _regmap_update_bits() doesn't allow us to do that because of commit
> > d91e8db2c3bb regmap: Suppress noop writes in regmap_update_bits()
> >
> > Is reverting it going to cause other issues? If yes then can we have a flag to specify forced update?
The usual thing to do here is an explicit write clearing the latch,
either immediately after setting it or immediately before setting it.
If the register is marked as volatile and the hardware doesn't read back
the latched state that also does the trick.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-12 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 14:32 [PATCH] can: c_can: use regmap_update_bits() to modify RAMINIT register Roger Quadros
2015-01-09 13:50 ` Tomi Valkeinen
2015-01-12 9:57 ` Roger Quadros
2015-01-12 10:02 ` Roger Quadros
2015-01-12 12:05 ` Mark Brown [this message]
2015-01-12 12:37 ` Roger Quadros
2015-01-12 12:43 ` Mark Brown
2015-01-13 14:23 ` [PATCH v2] " Roger Quadros
2015-01-15 14:37 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112120541.GD4160@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=rogerq@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).