Re: [PATCH] can-doc: Add missing semicolon to example

Re: [PATCH] can-doc: Add missing semicolon to example

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

On 11/09/2015 02:17 PM, Stefan Tatschner wrote:
> The example code for CAN_BCM,
> 
> 	connect(s, (struct sockaddr *)&addr, sizeof(addr))
> 
> lacks a semicolon at the end of the line. This patch adds that
> missing semicolon to ensure that the given code snippet actually
> compiles.
> 
> Signed-off-by: Stefan Tatschner <rumpelsepp@sevenbyte.org>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Jonathan, feel free to take the patch via your tree.

regards,
Marc

> ---
>  Documentation/networking/can.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/can.txt b/Documentation/networking/can.txt
> index 4636b94..05fd83b 100644
> --- a/Documentation/networking/can.txt
> +++ b/Documentation/networking/can.txt
> @@ -681,7 +681,7 @@ solution for a couple of reasons:
>      addr.can_family = AF_CAN;
>      addr.can_ifindex = ifr.ifr_ifindex;
>  
> -    connect(s, (struct sockaddr *)&addr, sizeof(addr))
> +    connect(s, (struct sockaddr *)&addr, sizeof(addr));
>  
>      (..)
>  
> 


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [PATCH] can-doc: Add missing semicolon to example

[Oliver Hartkopp]

On 09.11.2015 14:20, Marc Kleine-Budde wrote:
> On 11/09/2015 02:17 PM, Stefan Tatschner wrote:
>> The example code for CAN_BCM,
>>
>> 	connect(s, (struct sockaddr *)&addr, sizeof(addr))
>>
>> lacks a semicolon at the end of the line. This patch adds that
>> missing semicolon to ensure that the given code snippet actually
>> compiles.
>>
>> Signed-off-by: Stefan Tatschner <rumpelsepp@sevenbyte.org>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Jonathan, feel free to take the patch via your tree.
>
> regards,
> Marc
>

Hi Marc,

I was pretty disappointed that my last patch needed more than six weeks to 
emerge in Linus' merge window tree, where it needs additional three month 
until release. When this happens again, we'll have this doc fix in Linux 4.5 - 
for what reason?

I would suggest to send these kinds of doc fixes and enhancements together 
with other CAN fixes via Daves net tree without this needless delay.

Regards,
Oliver

>> ---
>>   Documentation/networking/can.txt | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/networking/can.txt b/Documentation/networking/can.txt
>> index 4636b94..05fd83b 100644
>> --- a/Documentation/networking/can.txt
>> +++ b/Documentation/networking/can.txt
>> @@ -681,7 +681,7 @@ solution for a couple of reasons:
>>       addr.can_family = AF_CAN;
>>       addr.can_ifindex = ifr.ifr_ifindex;
>>
>> -    connect(s, (struct sockaddr *)&addr, sizeof(addr))
>> +    connect(s, (struct sockaddr *)&addr, sizeof(addr));
>>
>>       (..)
>>
>>
>
>

Re: [PATCH] can-doc: Add missing semicolon to example

[Jonathan Corbet]

On Mon, 9 Nov 2015 14:20:51 +0100
Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> Jonathan, feel free to take the patch via your tree.

Applied to the docs tree, thanks.

jon

Re: [PATCH] can-doc: Add missing semicolon to example

[Oliver Hartkopp]

On 09.11.2015 19:01, Oliver Hartkopp wrote:

>> Jonathan, feel free to take the patch via your tree.
>>
>> regards,
>> Marc
>>
>
> Hi Marc,
>
> I was pretty disappointed that my last patch needed more than six weeks to
> emerge in Linus' merge window tree, where it needs additional three month
> until release. When this happens again, we'll have this doc fix in Linux 4.5 -
> for what reason?

Ok - this time we were lucky:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4aeabc6b5ca3b9d025f287978096e138bdfbdd35

> I would suggest to send these kinds of doc fixes and enhancements together
> with other CAN fixes via Daves net tree without this needless delay.

But I still suggest this process ...

Regards,
Oliver