Re: can: kvaser_usb: Add support for Kvaser CAN/USB devices

[Olivier Sobrie <olivier@sobrie.be>]

On Sat, Nov 21, 2015 at 01:40:05PM +0100, Oliver Hartkopp wrote:
> Hello Olivier,
> 
> On 11/20/2015 09:19 AM, Olivier Sobrie wrote:
> 
> > No it wasn't intentional. I think that it was inspired from other CAN
> > drivers. I see the same in net/can/c_can/c_can.c and
> > net/can/m_can/m_can.c. Sorry for the error.
> > Btw, which static checker are you using?
> > 
> > As suggested by Oliver, I assume we can transform this in
> >   cf->data[3] = CAN_ERR_PROT_LOC_CRC_SEQ;
> > and fix all the other places where bitwise operations are done
> > for errors in data[3].
> > 
> > Should I send a patch to fix this? Or do you or someone else plan
> > to send a patch?
> 
> I already prepared a patch to fix the data[3] assignment issue.
> 
> It's a bunch of drivers that do it wrong:
> 
> drivers/net/can/c_can/c_can.c:
> drivers/net/can/cc770/cc770.c:
> drivers/net/can/flexcan.c:
> drivers/net/can/m_can/m_can.c:
> drivers/net/can/pch_can.c:
> drivers/net/can/rcar_can.c:
> drivers/net/can/ti_hecc.c:
> drivers/net/can/usb/kvaser_usb.c:
> drivers/net/can/usb/usb_8dev.c:
> drivers/net/can/xilinx_can.c:
> 
> So if it's ok for you I'll post it this weekend :-)

Of course it's ok for me :-)
Thank you,

Olivier