Re: peak_pci: TX Frame Loss

[Andri Yngvason <andri.yngvason@marel.com>]

Hi Stephane,

On Tue, Dec 08, 2015 at 11:21:26AM +0100, Stephane Grosjean wrote:
> Hi!
> 
> Don't know atm what is buggier, but:
> 
> - the issue isn't reproducible with our Windows drivers,
> - the issue isn't reproducible with the pcan driver,
You have spin locks sprinkled around the pcan driver even where there isn't a
specific shared resource that's being protected.

However, a nice side-effect of that is that the interrupt routine is not allowed
to run concurrently with the xmit function, so the command register is never
written to so frequently as in the linux-can driver.
> 
[...]
> FYI, I have surrounded the _xmit() function as well as the ISR with couples
> of spin_lock/spin_unlock instructions, rebuild everything and have ran
> Andri's testbed... and guess what?
I don't know. I'm not sure if you hinted at the answer to this question. Did the
problem go away? I guess it did due to the reasons that I mentioned above.

This does not strike at the core of the issue. A targeted solution is to add a
delay.
> 
[...]
> 
> Le 03/12/2015 12:44, Marc Kleine-Budde a écrit :
> >On 12/03/2015 12:23 PM, Andri Yngvason wrote:
> >>I tried it and it's not enough. The sja1000 on the peak pci is an FPGA
> >>implementation that claims to be sja1000 compatible. Is it possible that peak's
> >>FPGA implementation is slower than the original sja1000?
> >Maybe buggier :)
> >
> >Marc
> >
> 

Regards,
Andri