From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: [PATCH] can-j1939: fix ifnullfree.cocci warnings Date: Tue, 6 Sep 2016 19:58:37 +0800 Message-ID: <20160906115837.GA136338@athens> References: <201609061930.NHHial3C%fengguang.wu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mga04.intel.com ([192.55.52.120]:14336 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753186AbcIFL7m (ORCPT ); Tue, 6 Sep 2016 07:59:42 -0400 Content-Disposition: inline In-Reply-To: <201609061930.NHHial3C%fengguang.wu@intel.com> Sender: linux-can-owner@vger.kernel.org List-ID: To: Kurt Van Dijck Cc: kbuild-all@01.org, linux-can@vger.kernel.org, Marc Kleine-Budde net/can/j1939/socket.c:528:3-8: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci CC: Kurt Van Dijck Signed-off-by: Fengguang Wu --- socket.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/net/can/j1939/socket.c +++ b/net/can/j1939/socket.c @@ -524,8 +524,7 @@ static int j1939sk_setsockopt(struct soc jsk->filters = filters; jsk->nfilters = count; spin_unlock_bh(&j1939_socks_lock); - if (ofilters) - kfree(ofilters); + kfree(ofilters); return 0; case SO_J1939_PROMISC: return j1939sk_setsockopt_flag(jsk, optval, optlen, PROMISC);