From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref' Date: Thu, 16 Apr 2020 08:43:32 +0200 Message-ID: <20200416064332.cbtmgnbwjityninz@gilmour.lan> References: <20200416005549.9683-1-robh@kernel.org> <20200416005549.9683-2-robh@kernel.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wl56qmwukpbi7dfb" Return-path: Content-Disposition: inline In-Reply-To: <20200416005549.9683-2-robh@kernel.org> Sender: netdev-owner@vger.kernel.org To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Stephen Boyd , Alexandre Torgue , Thierry Reding , Sam Ravnborg , Vinod Koul , Bartosz Golaszewski , Guenter Roeck , Jonathan Cameron , Dmitry Torokhov , Jacek Anaszewski , Pavel Machek , Mauro Carvalho Chehab , Lee Jones , Ulf Hansson , Heiko Stuebner , Andrew Lunn , Florian Fainelli List-Id: linux-can.vger.kernel.org --wl56qmwukpbi7dfb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 15, 2020 at 07:55:49PM -0500, Rob Herring wrote: > json-schema versions draft7 and earlier have a weird behavior in that > any keywords combined with a '$ref' are ignored (silently). The correct > form was to put a '$ref' under an 'allOf'. This behavior is now changed > in the 2019-09 json-schema spec and '$ref' can be mixed with other > keywords. The json-schema library doesn't yet support this, but the > tooling now does a fixup for this and either way works. > > This has been a constant source of review comments, so let's change this > treewide so everyone copies the simpler syntax. > > Signed-off-by: Rob Herring For allwinner, Acked-by: Maxime Ripard Maxime --wl56qmwukpbi7dfb Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXpf+lAAKCRDj7w1vZxhR xfXZAP9GMb4mpNd2CMjZwk5BxMrLzEIpKJTiQ4orqceXOWVHrwEA79RK8mnQLFzA 6mFAQXdPtJjk58zdTQSSSDo30M+OtQk= =foV0 -----END PGP SIGNATURE----- --wl56qmwukpbi7dfb--