Linux CAN drivers development
 help / color / mirror / Atom feed
From: Drew Fustini <drew@beagleboard.org>
To: Patrick Menschel <menschel.p@posteo.de>
Cc: linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>,
	Oliver Hartkopp <socketcan@hartkopp.net>
Subject: Re: isotp in mainline?
Date: Fri, 12 Jun 2020 17:36:41 +0200	[thread overview]
Message-ID: <20200612153641.GA3433528@x1> (raw)
In-Reply-To: <9d3bcfde-68f3-c9e0-4c63-cbae61915585@posteo.de>

On Fri, Jun 12, 2020 at 03:47:45PM +0200, Patrick Menschel wrote:
> Hi Drew,
> 
> > Is there a current effort to get the isotp driver accepted into mainline?
> 
> I believe ISOTP has been mainline for quite a while.
> 
> I remember writing a test script when Python 3.7 came out in Aug 2018
> and added the isotp socket type to socket class [1].
> 
> I tested on a X86_64 machine with Ubuntu 18.04 LTS, so it must have been
> mainline at that time.
> 
> Regards,
> Patrick
> 
> [1]
> https://docs.python.org/3.7/library/socket.html?highlight=socket#socket.CAN_ISOTP
>

Hi Patrick,

Maybe it was just to a test to see if the the protocol type existed?

It does look like the protocol is defined in include/uapi/linux/can.h:

#define CAN_ISOTP	6 /* ISO 15765-2 Transport Protocol */

However, there does not appear to be any implementation in the mainline
kernel.

I recall Oliver mentioning that he should try to mainline isotp modules
at the end of the J1939 talk at ELC-E last October [1]. I don't see any
posts regarding isotp in the linux-can archives since then, so I thought
I would bring it up.

Thanks,
Drew

[0] https://elixir.bootlin.com/linux/v5.7/source/include/uapi/linux/can.h#L159
[1] https://youtu.be/3NfN8B4-w8w?t=2052

  reply	other threads:[~2020-06-12 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 15:43 isotp in mainline? Drew Fustini
2020-06-12 13:47 ` Patrick Menschel
2020-06-12 15:36   ` Drew Fustini [this message]
2020-06-12 20:00     ` Patrick Menschel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200612153641.GA3433528@x1 \
    --to=drew@beagleboard.org \
    --cc=linux-can@vger.kernel.org \
    --cc=menschel.p@posteo.de \
    --cc=mkl@pengutronix.de \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox