Re: [net 10/15] can: tcan4x5x: tcan4x5x_can_probe(): add missing error checking for devm_regmap_init()

Dan Murphy
2020-11-17T14:01:52Z

Marc

On 11/15/20 11:41 AM, Marc Kleine-Budde wrote:
> This patch adds the missing error checking when initializing the regmap
> interface fails.
>
> Fixes: 5443c226ba91 ("can: tcan4x5x: Add tcan4x5x driver to the kernel")
> Cc: Dan Murphy <dmurphy@ti.com>
> Link: http://lore.kernel.org/r/20201019154233.1262589-7-mkl@pengutronix.de
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
> drivers/net/can/m_can/tcan4x5x.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/can/m_can/tcan4x5x.c b/drivers/net/can/m_can/tcan4x5x.c
> index eacd428e07e9..f058bd9104e9 100644
> --- a/drivers/net/can/m_can/tcan4x5x.c
> +++ b/drivers/net/can/m_can/tcan4x5x.c
> @@ -487,6 +487,10 @@ static int tcan4x5x_can_probe(struct spi_device *spi)
>
> priv->regmap = devm_regmap_init(&spi->dev, &tcan4x5x_bus,
> &spi->dev, &tcan4x5x_regmap);
> + if (IS_ERR(priv->regmap)) {
> + ret = PTR_ERR(priv->regmap);
> + goto out_clk;
> + }
>
> ret = tcan4x5x_power_enable(priv->power, 1);
> if (ret)

Reviewed-by: Dan Murphy<dmurphy@ti.com>