public inbox for linux-can@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Jonas <mark.jonas@de.bosch.com>
To: <mkl@pengutronix.de>
Cc: <linux-can@vger.kernel.org>, Wang Xin <xin.wang7@cn.bosch.com>,
	Mark Jonas <mark.jonas@de.bosch.com>
Subject: [PATCH] Fix attribute list size in do_get_nl_link()
Date: Tue, 17 Nov 2020 15:42:22 +0100	[thread overview]
Message-ID: <20201117144222.7809-1-mark.jonas@de.bosch.com> (raw)

From: Wang Xin <xin.wang7@cn.bosch.com>

The function do_get_nl_link() retrieves attributes from the response
RTM_NEWLINK. But it calculates the attribute list size with the wrong
structure struct ifaddrmsg. According to man 7 rtnetlink, RTM_NEWLINK
message uses struct ifinfomsg instead of struct ifaddrmsg.  This causes
that additional 8 bytes are parsed and garbage attributes might be
retrieved. One of consequences is that the message will be dropped if
the garbage attribute is IFLA_IFNAME and contains an invalid interface
name.

To fix this issue, use struct ifinfomsg to calculate the size of
attribute list for RTM_NEWLINK.

Signed-off-by: Wang Xin <xin.wang7@cn.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
 src/libsocketcan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libsocketcan.c b/src/libsocketcan.c
index c802849..60142cc 100644
--- a/src/libsocketcan.c
+++ b/src/libsocketcan.c
@@ -411,7 +411,7 @@ static int do_get_nl_link(int fd, __u8 acquire, const char *name, void *res)
 			struct rtattr *tb[IFLA_MAX + 1];
 
 			len =
-				nl_msg->nlmsg_len - NLMSG_LENGTH(sizeof(struct ifaddrmsg));
+				nl_msg->nlmsg_len - NLMSG_LENGTH(sizeof(struct ifinfomsg));
 			parse_rtattr(tb, IFLA_MAX, IFLA_RTA(ifi), len);
 
 			/* Finish process if the reply message is matched */
-- 
2.17.1


             reply	other threads:[~2020-11-17 14:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-17 14:42 Mark Jonas [this message]
2020-11-17 14:54 ` [PATCH] Fix attribute list size in do_get_nl_link() Marc Kleine-Budde
2020-11-17 15:28   ` AW: " Jonas Mark (BT-FIR/ENG1-Grb)
2020-11-17 15:53     ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201117144222.7809-1-mark.jonas@de.bosch.com \
    --to=mark.jonas@de.bosch.com \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=xin.wang7@cn.bosch.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox