From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 938BFC433E6 for ; Wed, 13 Jan 2021 07:58:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BC3923120 for ; Wed, 13 Jan 2021 07:58:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725899AbhAMH6d (ORCPT ); Wed, 13 Jan 2021 02:58:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbhAMH6d (ORCPT ); Wed, 13 Jan 2021 02:58:33 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 619BAC061795 for ; Tue, 12 Jan 2021 23:57:53 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id v3so601966plz.13 for ; Tue, 12 Jan 2021 23:57:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ag+62l7FscdCqShN85Yyg8UEbvTrunYmqAUNYOOMZaU=; b=ScG6kcaYOyomiKjOExW4auylmfaUmWTsiyUx8XQdkjk39c3EFYUMGWckr/PsIPFrkK a4q7wEp7i/TSgDx2TAFetHzdGkIoF298gGW6DTS049jtRL7x2eUPky0HzM4z9rSQuOhc PbqkxaKGgv3Awqn+9gxoX85x833z4S2sxaSiGvYAZZhtdjouLm4mzmotdTH0iHwtGn08 2kpKKgiQ4SsE/kYfN4la3lU1e/B/sFFXth/fWI6N6rSF+/TaXrMbF3b09MhcOXdtwnAI 7OhpeB9Dbiip8EnocrY2D3e8lNbu9bszgWAfy8xdLTG8aqXZM5wcvrStfTN8+fDImIRT kSQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ag+62l7FscdCqShN85Yyg8UEbvTrunYmqAUNYOOMZaU=; b=gsPdo4r7CjX3WGnKyrRfwPn1F4XNQvm67DjqtkCpCTkJyF0VYl9UecxKyh7/eXf2e0 VgH1JWdeJ5jcD3T6F7B6jbuUYqKFv7JsirgRlX+k7WCSOqDSq1SkxORGTyEyZdldq0k0 jtSlK5tCYRZsVFIGhtMEDHxiZ/YMyzgKrFtGhS0ECiPIaOmD5R4fAvwxg4h2iniK9QV+ F1qn6rFqwqxs9qcuAdZLawNLU1uHYXDFH6V57NXU/pCU06TcklzTogWxVBgp2mof6EZm Dxs0eZMyKLQCxMgk5a7F8QclO/h/Q+y/8Nh4NIPWf3IRxKUk2dCe6/p9ASJDE3ol9EUE vwSw== X-Gm-Message-State: AOAM5322VZf0UxLr2pUdL/nyL+KqknPvCoXX2AxTlvHfn5aLNqX7bxJt 3Yy9ENPgtvMROju3ZUwGyAkqVa+QnHWK X-Google-Smtp-Source: ABdhPJzu/imbhYQOZBtY7gE6mBGdu17tt8EdtBeYAkmNu0v4xUipVh2ZHucbn6ns2Iq16EGDav71Pg== X-Received: by 2002:a17:902:59c7:b029:de:25e7:2426 with SMTP id d7-20020a17090259c7b02900de25e72426mr927294plj.21.1610524672844; Tue, 12 Jan 2021 23:57:52 -0800 (PST) Received: from thinkpad ([2409:4072:6199:4cc7:6c7e:de01:2568:5545]) by smtp.gmail.com with ESMTPSA id gz2sm1579005pjb.2.2021.01.12.23.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jan 2021 23:57:52 -0800 (PST) Date: Wed, 13 Jan 2021 13:27:37 +0530 From: Manivannan Sadhasivam To: Qinglang Miao Cc: Marc Kleine-Budde , Thomas Kopp , Wolfgang Grandegger , "David S. Miller" , Jakub Kicinski , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] can: mcp251xfd: fix wrong check in mcp251xfd_handle_rxif_one Message-ID: <20210113075737.GA3763@thinkpad> References: <20210113073100.79552-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210113073100.79552-1-miaoqinglang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Wed, Jan 13, 2021 at 03:31:00PM +0800, Qinglang Miao wrote: > If alloc_canfd_skb returns NULL, 'cfg' is an uninitialized > variable, so we should check 'skb' rather than 'cfd' after > calling alloc_canfd_skb(priv->ndev, &cfd). > > Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") > Signed-off-by: Qinglang Miao Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- > drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c > index 77129d5f4..792d55ba4 100644 > --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c > +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c > @@ -1492,7 +1492,7 @@ mcp251xfd_handle_rxif_one(struct mcp251xfd_priv *priv, > else > skb = alloc_can_skb(priv->ndev, (struct can_frame **)&cfd); > > - if (!cfd) { > + if (!skb) { > stats->rx_dropped++; > return 0; > } > -- > 2.23.0 >