From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-can-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5F557C433DB
	for <linux-can@archiver.kernel.org>; Wed, 27 Jan 2021 04:57:09 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 2F9582064A
	for <linux-can@archiver.kernel.org>; Wed, 27 Jan 2021 04:57:09 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S238741AbhA0E4r (ORCPT <rfc822;linux-can@archiver.kernel.org>);
        Tue, 26 Jan 2021 23:56:47 -0500
Received: from mx2.suse.de ([195.135.220.15]:58406 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1730448AbhAZV3m (ORCPT <rfc822;linux-can@vger.kernel.org>);
        Tue, 26 Jan 2021 16:29:42 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 67145AC97;
        Tue, 26 Jan 2021 21:28:57 +0000 (UTC)
Date:   Tue, 26 Jan 2021 22:28:55 +0100
From:   Petr Vorel <pvorel@suse.cz>
To:     Richard Palethorpe <rpalethorpe@suse.de>
Cc:     Oliver Hartkopp <socketcan@hartkopp.net>, ltp@lists.linux.it,
        linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH v3 2/7] can: Add can_common.h for vcan device setup
Message-ID: <20210126212855.GC15365@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20210120143723.26483-1-rpalethorpe@suse.com>
 <20210120143723.26483-3-rpalethorpe@suse.com>
 <058a6f05-d5ca-0746-dc4e-007253d3a84d@hartkopp.net>
 <87bldd9t9i.fsf@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87bldd9t9i.fsf@suse.de>
Precedence: bulk
List-ID: <linux-can.vger.kernel.org>
X-Mailing-List: linux-can@vger.kernel.org

Hi Oliver, Richie,

> >> --- /dev/null
> >> +++ b/testcases/network/can/filter-tests/can_common.h
> >> @@ -0,0 +1,75 @@
> >> +// SPDX-License-Identifier: GPL-2.0-or-later
> >> +/*
> >> + * Copyright (c) 2021 SUSE LLC
> >> + */
> >> +
> >> +#include <stdio.h>
> >> +#include <stdlib.h>
> >> +#include <unistd.h>
> >> +#include <string.h>
> >> +
> >> +#include <sys/types.h>
> >> +#include <sys/socket.h>
> >> +#include <sys/ioctl.h>
> >> +#include <sys/time.h>
> >> +
> >> +#include "tst_cmd.h"
> >> +#include "tst_safe_stdio.h"
> >> +#include "tst_safe_file_ops.h"
> >> +
> >> +#include <linux/if.h>
> >> +#include <linux/can.h>
> >> +#include <linux/can/raw.h>
> >> +
> >> +#ifndef IFF_ECHO
> >> +# define IFF_ECHO (1<<18)
> >> +#endif
Thanks a lot, Richie!

> > IFF_ECHO was included into Linux 2.6.25 together with the CAN
> > subsystem itself.

> > So when you run the tests on Kernels < 2.6.25 you don't have CAN
> > support and don't need IFF_ECHO too.

> Petr, what kernel version and/or distro version did compilation fail on?

> There is a small chance someone might be compiling with old kernel
> headers relative to their kernel. However it is a challenge to compile
> LTP with such an old user land.

No, we don't support 2.6.25 :). I was playing with Buildroot distro in my spare time.
These embedded toolchains suffer compatibility problems (usually uclibc-ng and
sometimes musl lack the support). This problem was when using sourcery-arm-*.

But this is definitely not a blocker for this patchset. That lapi is not a must,
I can fix it some time later. I usually fix few of these problems before each
LTP release.

Kind regards,
Petr