Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree

Marc Kleine-Budde
2021-02-26T12:23:47Z

[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]

On 2/26/21 1:18 PM, Torin Cooper-Bennun wrote:
> Hi again. Going back to the start of our conversation:
>
> On Mon, Feb 15, 2021 at 03:45:09PM +0100, Marc Kleine-Budde wrote:
>> Sadly, the driver is still not in good shape...I think it will explode
>> as soon as you receive a CAN frame on the rpi, as the frames are passed
>> into the networking stack from the wrong context...
>>
>> Maybe I'll find some time to get receive properly working.
>
> Could you clarify what your concern is? netif_receive_skb seems to be
> used in the same way in m_can.c as in rx-offload.c.

The problem is that netif_receive_skb(skb) is called from a threaded interrupt
handler, but you should call it from NAPI.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: OpenPGP digital signature --]