Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree

Marc Kleine-Budde
2021-02-26T12:41:26Z

[-- Attachment #1.1: Type: text/plain, Size: 877 bytes --]

On 2/26/21 1:31 PM, Torin Cooper-Bennun wrote:
> On Fri, Feb 26, 2021 at 01:22:59PM +0100, Marc Kleine-Budde wrote:
>> The problem is that netif_receive_skb(skb) is called from a threaded interrupt
>> handler, but you should call it from NAPI.
>
> Ah, I was sure it was in fact called from NAPI, but that's only if
> is_peripheral is false. It should be as simple as getting rid of this
> switch, then, no?
>
> https://elixir.bootlin.com/linux/latest/source/drivers/net/can/m_can/m_can.c#L966

I think you cannot do (synchronous) SPI from NAPI (which is SoftIRQ context).

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

[-- Attachment #2: OpenPGP digital signature --]