Re: can, tcan4x5x: look to merge rpi support into rpi kernel tree

Torin Cooper-Bennun
2021-02-26T12:27:59Z

On Tue, Feb 16, 2021 at 01:32:35PM +0100, Marc Kleine-Budde wrote:
> If the number of blank frames equals the number of missing frames, then
> have a look where the message RAM is initialized:

This is the case, but it occurred over a matter of seconds (the frames
were only being sent about twice a second). I've finally got some time
to investigate, so I'll try to find out what's going on.

> https://elixir.bootlin.com/linux/latest/source/drivers/net/can/m_can/tcan4x5x.c#L335
>
> Oh! This doesn't look right :(
>
> I think it's a bad idea to first bring the chip into normal mode and
> then initialize the RAM.

I'm unsure whether this caused it, but needless to say, this is bad in
any case!

--
Regards,

Torin Cooper-Bennun
Software Engineer | maxiluxsystems.com