Re: mcp251x hangs during ifup

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1316 bytes --]

On 03.03.2021 10:00:47, ukrfoil.com, Cтудиопак Украина, Восточный регион wrote:
> this with the IRQ_TYPE_EDGE_FALLING value

> > That looks good, the IRQ is not shared. Can you test again with
> > IRQ_TYPE_EDGE_FALLING in the DT instead of IRQ_TYPE_LEVEL_LOW?

Doh! Need more coffee.

Of course I mean try with IRQ_TYPE_LEVEL_LOW and check if the unmodified
mcp2515 driver with disable_irq() does work then.

> >
> > | can0: can@0 {
> > |       reg = <0>;
> > |       compatible = "microchip,mcp2515";
> > |       pinctrl-names = "default";
> > |       pinctrl-0 = <&can0_pin_irq>;
> > |       interrupt-parent = <&pio>;
> > |       interrupts = <6 8 IRQ_TYPE_EDGE_FALLING>;
> >
> > You better use IRQ_TYPE_LEVEL_LOW instead of IRQ_TYPE_EDGE_FALLING, but
> > that's unrelated to this problem.
> >
> > |       clocks = <&can0_osc_fixed>;
> > |       spi-max-frequency = <10000000>;
> > |       gpio-controller;
> > |       gpio-cells = <2>;
> > |       status = "okay";
> > | };

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]