[PATCH] can: m_can: reset IR_RF0L in message reception loop

Mariusz Madej
2021-03-01T21:29:17Z

Message lost warning is reported in loop without interrupt reset. Besides
redundant log messages it may lead to serious performance problem, where
fifo gets full faster than next reception is scheduled by NAPI. This
patch fixes it.

Signed-off-by: Mariusz Madej <mariusz.madej@xtrack.com>
---
drivers/net/can/m_can/m_can.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 3752520a7..bd5539435 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -501,8 +501,10 @@ static int m_can_do_rx_poll(struct net_device *dev, int quota)
}

while ((rxfs & RXFS_FFL_MASK) && (quota > 0)) {
- if (rxfs & RXFS_RFL)
+ if (rxfs & RXFS_RFL) {
netdev_warn(dev, "Rx FIFO 0 Message Lost\n");
+ m_can_write(cdev, M_CAN_IR, IR_RF0L);
+ }

m_can_read_fifo(dev, rxfs);

--
2.20.1