From: Torin Cooper-Bennun <torin@maxiluxsystems.com>
To: linux-can@vger.kernel.org
Cc: mkl@pengutronix.de,
Torin Cooper-Bennun <torin@maxiluxsystems.com>,
Mariusz Madej <mariusz.madej@xtrack.com>
Subject: [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning
Date: Wed, 3 Mar 2021 10:31:52 +0000 [thread overview]
Message-ID: <20210303103151.3760532-1-torin@maxiluxsystems.com> (raw)
Message loss from RX FIFO 0 is already handled in m_can_handle_lost_msg,
with netdev output included.
Removing this warning also improves driver performance under heavy load,
where m_can_do_rx_poll may be called many times before this interrupt is
cleared, causing this message to be output many times (thanks Mariusz
Madej for this report).
Cc: Mariusz Madej <mariusz.madej@xtrack.com>
Signed-off-by: Torin Cooper-Bennun <torin@maxiluxsystems.com>
---
drivers/net/can/m_can/m_can.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 3752520a7d4b..d783c46cac16 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -501,9 +501,6 @@ static int m_can_do_rx_poll(struct net_device *dev, int quota)
}
while ((rxfs & RXFS_FFL_MASK) && (quota > 0)) {
- if (rxfs & RXFS_RFL)
- netdev_warn(dev, "Rx FIFO 0 Message Lost\n");
-
m_can_read_fifo(dev, rxfs);
quota--;
--
2.30.1
next reply other threads:[~2021-03-04 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 10:31 Torin Cooper-Bennun [this message]
2021-03-04 13:22 ` [PATCH] can: m_can: m_can_do_rx_poll(): fix extraneous msg loss warning Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303103151.3760532-1-torin@maxiluxsystems.com \
--to=torin@maxiluxsystems.com \
--cc=linux-can@vger.kernel.org \
--cc=mariusz.madej@xtrack.com \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox