From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B13AC433E0 for ; Wed, 10 Mar 2021 06:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4B2664FF2 for ; Wed, 10 Mar 2021 06:47:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbhCJGqx (ORCPT ); Wed, 10 Mar 2021 01:46:53 -0500 Received: from mx1.emlix.com ([136.243.223.33]:40960 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbhCJGq2 (ORCPT ); Wed, 10 Mar 2021 01:46:28 -0500 Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id C58F05FED7; Wed, 10 Mar 2021 07:46:26 +0100 (CET) Date: Wed, 10 Mar 2021 07:46:26 +0100 From: Daniel =?iso-8859-1?Q?Gl=F6ckner?= To: netdev@vger.kernel.org, linux-can@vger.kernel.org Cc: Marc Kleine-Budde Subject: Softirq error with mcp251xfd driver Message-ID: <20210310064626.GA11893@homes.emlix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi, the mcp251xfd driver uses a threaded irq handler to queue skbs with the can_rx_offload_* helpers. I get the following error on every packet until the rate limit kicks in: NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!! Adding local_bh_disable/local_bh_enable around the can_rx_offload_* calls gets rid of the error, but is that the correct way to fix this? Internally the can_rx_offload code uses spin_lock_irqsave to safely manipulate its queue. Best regards, Daniel