public inbox for linux-can@vger.kernel.org
 help / color / mirror / Atom feed
From: coverity-bot <keescook@chromium.org>
To: Torin Cooper-Bennun <torin@maxiluxsystems.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
	"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	linux-next@vger.kernel.org
Subject: Coverity: m_can_receive_skb(): Error handling issues
Date: Wed, 31 Mar 2021 15:00:00 -0700	[thread overview]
Message-ID: <202103311500.C1214192BE@keescook> (raw)

Hello!

This is an experimental semi-automated report about issues detected by
Coverity from a scan of next-20210331 as part of the linux-next scan project:
https://scan.coverity.com/projects/linux-next-weekly-scan

You're getting this email because you were associated with the identified
lines of code (noted below) that were touched by commits:

  None
    1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context")

Coverity reported the following:

*** CID 1503583:  Error handling issues  (CHECKED_RETURN)
/drivers/net/can/m_can/m_can.c: 470 in m_can_receive_skb()
464     */
465     static void m_can_receive_skb(struct m_can_classdev *cdev,
466     			      struct sk_buff *skb,
467     			      u32 timestamp)
468     {
469     	if (cdev->is_peripheral)
vvv     CID 1503583:  Error handling issues  (CHECKED_RETURN)
vvv     Calling "can_rx_offload_queue_sorted" without checking return value (as is done elsewhere 7 out of 8 times).
470     		can_rx_offload_queue_sorted(&cdev->offload, skb, timestamp);
471     	else
472     		netif_receive_skb(skb);
473     }
474
475     static void m_can_read_fifo(struct net_device *dev, u32 rxfs)

If this is a false positive, please let us know so we can mark it as
such, or teach the Coverity rules to be smarter. If not, please make
sure fixes get into linux-next. :) For patches fixing this, please
include these lines (but double-check the "Fixes" first):

Reported-by: coverity-bot <keescook+coverity-bot@chromium.org>
Addresses-Coverity-ID: 1503583 ("Error handling issues")
Fixes: 1be37d3b0414 ("can: m_can: fix periph RX path: use rx-offload to ensure skbs are sent from softirq context")

Thanks for your attention!

-- 
Coverity-bot


                 reply	other threads:[~2021-04-01  8:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202103311500.C1214192BE@keescook \
    --to=keescook@chromium.org \
    --cc=gustavo@embeddedor.com \
    --cc=linux-next@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=torin@maxiluxsystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox