public inbox for linux-can@vger.kernel.org
 help / color / mirror / Atom feed
From: Torin Cooper-Bennun <torin@maxiluxsystems.com>
To: linux-can@vger.kernel.org
Subject: [PATCH RFC can-next 0/3] m_can: support device-specific interrupt handling
Date: Fri, 14 May 2021 13:19:43 +0100	[thread overview]
Message-ID: <20210514121946.2344901-1-torin@maxiluxsystems.com> (raw)

Using the TCAN4550, I've had occasions where the m_can driver has fallen
over with the "nobody cared" message -- the ISR has returned IRQ_NONE
upon "99,900 of the previous 100,000 interrupts" (see
kernel/irq/spurious.c, __report_bad_irq()).

While such high numbers certainly indicate some kind of fault,
presently, device-specific interrupts are totally ignored -- it may be
that such a fault can be handled with a device-specific action.

Comments are welcome. One thing right off the bat: I'm not sure whether
the new callback should be added alongside clear_interrupts, or if it
should replace it.

I also need to replicate the fault observed with the TCAN4550 - it's
unlikely that the handling added in this patchset is effective by
itself.

Torin Cooper-Bennun (3):
  can: m_can: add handle_dev_interrupts callback to m_can_ops
  can: m_can: m_can_isr(): handle device-specific interrupts
  can: tcan4x5x: add handle_dev_interrupts callback to ops

 drivers/net/can/m_can/m_can.c         | 13 ++++++++++++-
 drivers/net/can/m_can/m_can.h         |  2 ++
 drivers/net/can/m_can/tcan4x5x-core.c | 25 +++++++++++++++++++++++++
 3 files changed, 39 insertions(+), 1 deletion(-)



             reply	other threads:[~2021-05-14 12:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 12:19 Torin Cooper-Bennun [this message]
2021-05-14 12:19 ` [PATCH RFC can-next 1/3] can: m_can: add handle_dev_interrupts callback to m_can_ops Torin Cooper-Bennun
2021-05-14 12:26   ` Marc Kleine-Budde
2021-05-14 13:21     ` Torin Cooper-Bennun
2021-05-14 14:16       ` Marc Kleine-Budde
2021-05-14 12:19 ` [PATCH RFC can-next 2/3] can: m_can: m_can_isr(): handle device-specific interrupts Torin Cooper-Bennun
2021-05-14 12:19 ` [PATCH RFC can-next 3/3] can: tcan4x5x: add handle_dev_interrupts callback to ops Torin Cooper-Bennun
2021-05-14 14:10   ` Marc Kleine-Budde
2021-05-14 14:51     ` Torin Cooper-Bennun
2021-05-14 15:15       ` Marc Kleine-Budde
2021-05-14 16:27         ` Torin Cooper-Bennun
2021-05-14 12:34 ` [PATCH RFC can-next 0/3] m_can: support device-specific interrupt handling Marc Kleine-Budde
2021-05-14 13:10   ` Torin Cooper-Bennun
2021-05-14 14:12     ` Marc Kleine-Budde
2021-05-14 14:44       ` Torin Cooper-Bennun
2021-05-14 14:55         ` Marc Kleine-Budde
2021-05-14 16:46           ` Torin Cooper-Bennun
2021-05-14 14:54       ` Torin Cooper-Bennun
2021-05-14 15:21         ` Marc Kleine-Budde
2021-05-14 16:44           ` Torin Cooper-Bennun
2021-05-14 17:13             ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514121946.2344901-1-torin@maxiluxsystems.com \
    --to=torin@maxiluxsystems.com \
    --cc=linux-can@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox