From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Angelo Dureghello <angelo@kernel-space.org>,
Greg Ungerer <gerg@linux-m68k.org>,
Wolfgang Grandegger <wg@grandegger.com>,
Linux/m68k <linux-m68k@vger.kernel.org>,
linux-can@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>
Subject: Re: [PATCH v3 4/5] can: flexcan: update Kconfig to allow non-of cases
Date: Tue, 22 Jun 2021 08:54:27 +0200 [thread overview]
Message-ID: <20210622065427.z5dnixenf47zag4g@pengutronix.de> (raw)
In-Reply-To: <CAMuHMdUrFa6r2VQdNTgr8mV_wGoOb4VhK0Y5_XQQ1Xzgc93NMw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
On 22.06.2021 08:52:05, Geert Uytterhoeven wrote:
> > Probably. What about the original proposed change: "(OF || M5441x) && HAS_IOMEM"?
>
> Yeah, the Flexcan might pop up on RISC-V, too.
> But any new platforms should use OF.
> Given the Flexcan is probably present on more than just M5441x,
> I'd go for:
>
> depends on OF || COLDFIRE || COMPILE_TEST
> depends on HAS_IOMEM
Looks good to me!
> > > > So I think there won't be too many configs where the oldconfig question
> > > > would pop up.
> > >
> > > Now it will, as Mr. Torvalds' main machine does not satisfy "ARM || PPC"
> > > or "OF && HAS_IOMEM", but does "HAS_IOMEM" ;-)
> >
> > IC, that would be one question too much :)
>
> I do doubt he has CONFIG_CAN enabled ;-)
:D
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-22 6:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 18:46 [PATCH v3 1/5] can: flexcan: add platform data header Angelo Dureghello
2021-06-21 18:46 ` [PATCH v3 2/5] m68k: stmark2: update board setup Angelo Dureghello
2021-06-21 18:46 ` [PATCH v3 3/5] m68k: m5441x: add flexcan support Angelo Dureghello
2021-06-21 18:46 ` [PATCH v3 4/5] can: flexcan: update Kconfig to allow non-of cases Angelo Dureghello
2021-06-21 20:11 ` Geert Uytterhoeven
2021-06-21 20:18 ` Marc Kleine-Budde
2021-06-21 20:22 ` Geert Uytterhoeven
2021-06-21 20:41 ` Marc Kleine-Budde
2021-06-22 6:52 ` Geert Uytterhoeven
2021-06-22 6:54 ` Marc Kleine-Budde [this message]
2021-06-26 12:18 ` Angelo Dureghello
2021-06-21 18:46 ` [PATCH v3 5/5] can: flexcan: add mcf5441x support Angelo Dureghello
2021-06-21 19:19 ` Marc Kleine-Budde
2021-06-27 14:54 ` Angelo Dureghello
2021-06-21 18:59 ` [PATCH v3 1/5] can: flexcan: add platform data header Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622065427.z5dnixenf47zag4g@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=angelo@kernel-space.org \
--cc=geert@linux-m68k.org \
--cc=gerg@linux-m68k.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox