Re: [PATCH] can: mcba_usb: fix memory leak in mcba_usb

[Pavel Skripkin <paskripkin@gmail.com>]

On Sun, 25 Jul 2021 11:42:46 +0200
Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 25.07.2021 11:12:42, Pavel Skripkin wrote:
> > Can You try the following patch?
> 
> Can you create a proper patch with you S-o-b?
> 
Hi, Marc.

Sure! I thought about a bit diffrent fix path like:
diff -> Yasushi's test -> patch with Tested-by tag. I guess, your
approach is more standard, so, I will send pacth as reply to your email.

Thanks!

> > diff --git a/drivers/net/can/usb/mcba_usb.c
> > b/drivers/net/can/usb/mcba_usb.c index a45865bd7254..a1a154c08b7f
> > 100644 --- a/drivers/net/can/usb/mcba_usb.c
> > +++ b/drivers/net/can/usb/mcba_usb.c
> > @@ -653,6 +653,8 @@ static int mcba_usb_start(struct mcba_priv
> > *priv) break;
> >  		}
> >  
> > +		urb->transfer_dma = buf_dma;
> > +
> >  		usb_fill_bulk_urb(urb, priv->udev,
> >  				  usb_rcvbulkpipe(priv->udev,
> > MCBA_USB_EP_IN), buf, MCBA_USB_RX_BUFF_SIZE,
> > 
> > 
> > 
> > I've added Marc to this discussion, I believe, he can help us,
> > since he is CAN maintainer.
> 
> Yasushi, please test and post your Tested-by here. After Pavel posts a
> proper patch and you tested it, I'll forward it to net/master, then it
> will be applied to the stable kernels. Debian can even pick up the
> patch earlier.
> 
> regards,
> Marc
> 



With regards,
Pavel Skripkin