From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Aswath Govindraju <a-govindraju@ti.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>,
Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Matt Kline <matt@bitbashing.io>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: m_can: m_can_platform: Fix iomap_read_fifo() and iomap_write_fifo()
Date: Sun, 17 Oct 2021 22:44:12 +0200 [thread overview]
Message-ID: <20211017204412.2jvp24tgaibvmcz3@pengutronix.de> (raw)
In-Reply-To: <20210920123344.2320-1-a-govindraju@ti.com>
[-- Attachment #1: Type: text/plain, Size: 952 bytes --]
On 20.09.2021 18:03:43, Aswath Govindraju wrote:
> The read and writes from the fifo are from a buffer, with various fields
> and data at predefined offsets. So, they should not be done to the same
> address(or port) in case of val_count greater than 1. Therefore, fix this
> by using iowrite32/ioread32 instead of ioread32_rep/iowrite32_rep.
>
> Also, the write into fifo must be performed with an offset from the message
> ram base address. Therefore, fix the base address to mram_base.
>
> Fixes: e39381770ec9 ("can: m_can: Disable IRQs on FIFO bus errors")
> Signed-off-by: Aswath Govindraju <a-govindraju@ti.com>
Applied to linux-can/testing.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-10-17 20:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:33 [PATCH] can: m_can: m_can_platform: Fix iomap_read_fifo() and iomap_write_fifo() Aswath Govindraju
2021-10-17 20:44 ` Marc Kleine-Budde [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-20 12:26 Aswath Govindraju
2021-09-20 12:27 ` Aswath Govindraju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211017204412.2jvp24tgaibvmcz3@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=a-govindraju@ti.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=matt@bitbashing.io \
--cc=netdev@vger.kernel.org \
--cc=rcsekar@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox