From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E50E8C433EF for ; Thu, 28 Oct 2021 08:31:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BE7E5610C8 for ; Thu, 28 Oct 2021 08:31:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230080AbhJ1Id0 (ORCPT ); Thu, 28 Oct 2021 04:33:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229791AbhJ1IdZ (ORCPT ); Thu, 28 Oct 2021 04:33:25 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A0DAC061570 for ; Thu, 28 Oct 2021 01:30:59 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mg0oB-00045G-SJ; Thu, 28 Oct 2021 10:30:47 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mg0oA-0007Qs-Fn; Thu, 28 Oct 2021 10:30:46 +0200 Date: Thu, 28 Oct 2021 10:30:46 +0200 From: Oleksij Rempel To: Zhang Changzhong Cc: Robin van der Gracht , linux-kernel@vger.kernel.org, Oleksij Rempel , netdev@vger.kernel.org, Marc Kleine-Budde , kernel@pengutronix.de, Oliver Hartkopp , Jakub Kicinski , linux-can@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH net 2/3] can: j1939: j1939_can_recv(): ignore messages with invalid source address Message-ID: <20211028083046.GF20681@pengutronix.de> References: <1634825057-47915-1-git-send-email-zhangchangzhong@huawei.com> <1634825057-47915-3-git-send-email-zhangchangzhong@huawei.com> <20211022102306.GB20681@pengutronix.de> <9c636d7f-70df-18c9-66ed-46eb21f4ffbb@huawei.com> <20211028065144.GE20681@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 10:29:58 up 252 days, 11:53, 140 users, load average: 0.15, 0.51, 0.43 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org On Thu, Oct 28, 2021 at 03:33:21PM +0800, Zhang Changzhong wrote: > On 2021/10/28 14:51, Oleksij Rempel wrote: > > Hi, > > > > On Mon, Oct 25, 2021 at 03:30:57PM +0800, Zhang Changzhong wrote: > >> On 2021/10/22 18:23, Oleksij Rempel wrote: > >>> On Thu, Oct 21, 2021 at 10:04:16PM +0800, Zhang Changzhong wrote: > >>>> According to SAE-J1939-82 2015 (A.3.6 Row 2), a receiver should never > >>>> send TP.CM_CTS to the global address, so we can add a check in > >>>> j1939_can_recv() to drop messages with invalid source address. > >>>> > >>>> Fixes: 9d71dd0c7009 ("can: add support of SAE J1939 protocol") > >>>> Signed-off-by: Zhang Changzhong > >>> > >>> NACK. This will break Address Claiming, where first message is SA == 0xff > >> > >> I know that 0xfe can be used as a source address, but which message has a source > >> address of 0xff? > >> > >> According to SAE-J1939-81 2017 4.2.2.8： > >> > >> The network address 255, also known as the Global address, is permitted in the > >> Destination Address field of the SAE J1939 message identifier but never in the > >> Source Address field. > > > > You are right. Thx! > > > > Are you using any testing frameworks? > > Can you please take a look here: > > https://github.com/linux-can/can-tests/tree/master/j1939 > > > > We are using this scripts for regression testing of some know bugs. > > Great! I'll run these scripts before posting patches. You are welcome to extend this tests :) Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |