linux-can.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Max Staudt <max@enpas.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	linux-can@vger.kernel.org, Oliver Neukum <oneukum@suse.com>,
	linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.com>
Subject: Re: [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based OBD-II adapters
Date: Mon, 7 Mar 2022 23:00:17 +0100	[thread overview]
Message-ID: <20220307230017.4332d602.max@enpas.org> (raw)
In-Reply-To: <YiZ/5WaNHhaONjX1@kroah.com>

On Mon, 7 Mar 2022 22:57:57 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Mon, Mar 07, 2022 at 10:43:03PM +0100, Max Staudt wrote:
> > +    sudo ldattach \
> > +           --debug \
> > +           --speed 38400 \
> > +           --eightbits \
> > +           --noparity \
> > +           --onestopbit \
> > +           --iflag -ICRNL,INLCR,-IXOFF \
> > +           29 \
> > +           /dev/ttyUSB0  
> 
> I think you mean "30" here, not "29", right?

Right.  m-(

Thanks for catching this. I'll wait for more updates before sending v4.


Max

  reply	other threads:[~2022-03-07 22:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 21:43 [PATCH v3] can, tty: elmcan CAN/ldisc driver for ELM327 based OBD-II adapters Max Staudt
2022-03-07 21:57 ` Greg Kroah-Hartman
2022-03-07 22:00   ` Max Staudt [this message]
2022-03-08  7:01 ` Vincent Mailhol
2022-03-09 12:54   ` Max Staudt
2022-03-09 13:49     ` Vincent Mailhol
2022-03-12 21:21       ` Max Staudt
2022-03-15 10:21         ` Marc Kleine-Budde
2022-03-17 21:05           ` Max Staudt
2022-03-14 22:04       ` Marc Kleine-Budde
2022-03-17 20:23         ` Max Staudt
2022-03-17 20:57           ` Marc Kleine-Budde
2022-03-17 21:08             ` Max Staudt
2022-03-14 22:00   ` Marc Kleine-Budde
2022-03-14 21:58 ` Marc Kleine-Budde
2022-03-17 20:18   ` Max Staudt
2022-03-17 20:55     ` Marc Kleine-Budde
2022-03-21  2:06       ` Max Staudt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307230017.4332d602.max@enpas.org \
    --to=max@enpas.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=oneukum@suse.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).