From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Rhett Aultman <rhett.aultman@samsara.com>
Cc: linux-can@vger.kernel.org,
Vasanth Sadhasivan <vasanth.sadhasivan@samsara.com>
Subject: Re: [PATCH v2] can: gs_usb: remove dma allocations
Date: Fri, 23 Sep 2022 14:12:01 +0200 [thread overview]
Message-ID: <20220923121201.f5rllcey7enwss4e@pengutronix.de> (raw)
In-Reply-To: <20220923121110.luq5xwrlflgstlku@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]
On 23.09.2022 14:11:11, Marc Kleine-Budde wrote:
> On 20.09.2022 11:47:24, Rhett Aultman wrote:
> > From: Vasanth Sadhasivan <vasanth.sadhasivan@samsara.com>
> >
> > DMA allocated buffers are a precious resource. If there is no need for DMA
> > allocations, then it might be worth to use non-dma allocated buffers.
> > After testing the gs_usb driver with and without DMA allocation, there
> > does not seem to be a significant change in latency or cpu utilization
> > either way. Therefore, DMA allocation is not necessary and removed.
> > Internal buffers used within urbs were managed and freed manually. These
> > buffers are no longer needed to be managed by the driver. The
> > URB_FREE_BUFFER flag, allows for the buffers in question to
> > be automatically freed.
> >
> > Co-developed-by: Rhett Aultman <rhett.aultman@samsara.com>
> > Signed-off-by: Rhett Aultman <rhett.aultman@samsara.com>
> > Signed-off-by: Vasanth Sadhasivan <vasanth.sadhasivan@samsara.com>
>
> Applied to linux-can.
linux-can-next that is.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-09-23 12:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 20:41 [PATCH 0/1] can: gs_usb: remove dma allocations Rhett Aultman
2022-09-13 20:41 ` [PATCH 1/1] " Rhett Aultman
2022-09-18 21:31 ` Marc Kleine-Budde
2022-09-20 15:47 ` [PATCH 0/1] " Rhett Aultman
2022-09-20 15:47 ` [PATCH v2] " Rhett Aultman
2022-09-23 12:11 ` Marc Kleine-Budde
2022-09-23 12:12 ` Marc Kleine-Budde [this message]
2022-09-20 15:50 ` [PATCH 0/1] " Rhett Aultman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923121201.f5rllcey7enwss4e@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=rhett.aultman@samsara.com \
--cc=vasanth.sadhasivan@samsara.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox