From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEBCCC433FE for ; Thu, 6 Oct 2022 16:38:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230419AbiJFQiC (ORCPT ); Thu, 6 Oct 2022 12:38:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiJFQiC (ORCPT ); Thu, 6 Oct 2022 12:38:02 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DFFCCE9BD for ; Thu, 6 Oct 2022 09:38:01 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=bjornoya.blackshift.org) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogTsl-0004jt-SP; Thu, 06 Oct 2022 18:37:59 +0200 Received: from pengutronix.de (unknown [IPv6:2a01:4f8:1c1c:29e9:22:41ff:fe00:1400]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: mkl-all@blackshift.org) by smtp.blackshift.org (Postfix) with ESMTPSA id 3967FF6695; Thu, 6 Oct 2022 16:37:59 +0000 (UTC) Date: Thu, 6 Oct 2022 18:37:57 +0200 From: Marc Kleine-Budde To: linux-can@vger.kernel.org Cc: Jeroen Hofstee Subject: Re: [PATCH 6/6] can: gs_usb: support reading error counters Message-ID: <20221006163757.whj3q2bavfu6mt4k@pengutronix.de> References: <20221006162452.200322-1-mkl@pengutronix.de> <20221006162452.200322-7-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="acq3eyhv7ujrpalm" Content-Disposition: inline In-Reply-To: <20221006162452.200322-7-mkl@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: mkl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-can@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --acq3eyhv7ujrpalm Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 06.10.2022 18:24:52, Marc Kleine-Budde wrote: > From: Jeroen Hofstee >=20 > the format of this message is a bit weird, single bytes would be > sufficient. At the moment it uses the existing struct gs_device_state. =46rom my point of view this looks good. The struct gs_device_state wasn't used at all, yet! This is a good use of it. Marc --=20 Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --acq3eyhv7ujrpalm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmM/BGMACgkQrX5LkNig 011QRwgAtEa3I7+ILvMiv8XsyjMLwgCwk92EjwR+YYo82B4WCSZujAhrFrGlSK5H sgNgNRiVydmIYwtEXHKmDxRzTTei1CymTMGXR5LT4eVTf/WhRC7jvdSPNU6wHwIL J6KficpUfiBadwZO0EV4sEyCf1CHrog8Iqz2hIiD1YfhNL73I2ShUUQTsZVQQWRP v2BgTw1+at39UWQ4fOwddh5L2FpCnvOf/330oWD9yXqhxMPTAaF6RN2CRbtYe1VT 1n7Lyikj7ZvFgYAy358yDzPgauj1vRnjRUSJOe9msrRExm/R4BXiyKT7Fkg82kJY y3oRuubhh7KOs82L/NMh+FUk3hvEXw== =bfwt -----END PGP SIGNATURE----- --acq3eyhv7ujrpalm--