Re: [PATCH v5 2/4] can: ctucanfd: add HW timestamps to RX and error CAN frames

[Pavel Pisa <pisa@cmp.felk.cvut.cz>]

Hello Marc,

On Monday 17 of October 2022 14:11:22 Marc Kleine-Budde wrote:
> On 16.10.2022 23:54:48, Pavel Pisa wrote:
> [...]
>
> > I hope/expect that it is not problem to call clk_prepare_enable twice
> > on same reference when the clocks are the same. As I read the code the
> > state is counted. If it is a problem then some if has to be put there
> > when the core and timestamp clock are the same.
>
> The clock prepare and enable are counting. If you call then twice, you
> have to call disable and unprepare twice, too, to shut it down. This is
> widely used in the kernel, e.g. if the same clock is passed to several
> IP cores.

Thanks for confirmation of my understanding.

As to move formward, is the referenced Matej Vasilevski's
series acceptable by you or do you see some problems still?

I have ACKed this patch, I consider it as functional
for mainline and good base for our further testing
and development.

Should I ACK others as well or Reviewed-by: Rob Herring
is enough for deice tree?

The last one is exactly reaction to your comment and the
documentation is evident.

Best wishes,

                Pavel
-- 
                Pavel Pisa
    phone:      +420 603531357
    e-mail:     pisa@cmp.felk.cvut.cz
    Department of Control Engineering FEE CVUT
    Karlovo namesti 13, 121 35, Prague 2
    university: http://control.fel.cvut.cz/
    personal:   http://cmp.felk.cvut.cz/~pisa
    projects:   https://www.openhub.net/accounts/ppisa
    CAN related:http://canbus.pages.fel.cvut.cz/
    RISC-V education: https://comparch.edu.cvut.cz/
    Open Technologies Research Education and Exchange Services
    https://gitlab.fel.cvut.cz/otrees/org/-/wikis/home