Re: [PATCH v2 2/3] can: rcar_canfd: Fix channel specific IRQ handling for RZ/G2L

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1460 bytes --]

On 26.10.2022 09:34:41, Biju Das wrote:
> > In a separate patch, please clean up these, too:
> > 
> > | static void rcar_canfd_handle_global_err(struct rcar_canfd_global
> > | *gpriv, u32 ch) static void rcar_canfd_handle_global_receive(struct
> > | rcar_canfd_global *gpriv, u32 ch) static void
> > | rcar_canfd_channel_remove(struct rcar_canfd_global *gpriv, u32 ch)
> > 
> > Why are 2 of the above functions called "global" as they work on a
> > specific channel? That can be streamlined, too.
> > 
> 
> The function name is as per the hardware manual, Interrupt sources are
> classified into global and channel interrupts.
> 
> • Global interrupts (2 sources):
> — Receive FIFO interrupt
> — Global error interrupt
> • Channel interrupts (3 sources/channel):

I see. Keep the functions as is.

> Maybe we could change
> "rcar_canfd_handle_global_receive"->"rcar_canfd_handle_channel_receive",
> as from driver point It is not global anymore?? Please let me know.

Never mind - the gpriv and channel numbers are needed sometimes even in
the functions working on a single channel. Never mind. I'll take patches
1 and 2 as they are.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]