From: Max Staudt <max@enpas.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
dario.binacchi@amarulasolutions.com,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Palethorpe <richard.palethorpe@suse.com>,
Petr Vorel <petr.vorel@suse.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] can: slcan: fix freed work crash
Date: Sat, 3 Dec 2022 00:32:11 +0900 [thread overview]
Message-ID: <20221203003211.4c6a63b9.max@enpas.org> (raw)
In-Reply-To: <20221202152701.ewnillsqded7uby4@pengutronix.de>
This patch fixes the crash, but is IMHO incomplete: The flush_work() in
.ndo_stop() should also be removed, since its existence implies
unexpected behaviour.
In other words, my moving it there in can327 was a double mistake, and
slcan just happened to copy my mistake over.
I'm preparing a patch for can327, and it will remove the flush from
.ndo_stop(). What shall we do about slcan?
Max
prev parent reply other threads:[~2022-12-02 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 7:34 [PATCH] can: slcan: fix freed work crash Jiri Slaby (SUSE)
2022-12-01 10:13 ` Petr Vorel
2022-12-01 18:52 ` Max Staudt
2022-12-02 12:14 ` Marc Kleine-Budde
2022-12-02 15:27 ` Marc Kleine-Budde
2022-12-02 15:32 ` Max Staudt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221203003211.4c6a63b9.max@enpas.org \
--to=max@enpas.org \
--cc=dario.binacchi@amarulasolutions.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petr.vorel@suse.com \
--cc=richard.palethorpe@suse.com \
--cc=stable@vger.kernel.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).