Linux CAN drivers development
 help / color / mirror / Atom feed
From: Markus Schneider-Pargmann <msp@baylibre.com>
To: Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Wolfgang Grandegger <wg@grandegger.com>
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Markus Schneider-Pargmann <msp@baylibre.com>
Subject: [PATCH v2 07/11] can: m_can: Batch acknowledge rx fifo
Date: Tue,  6 Dec 2022 12:57:24 +0100	[thread overview]
Message-ID: <20221206115728.1056014-8-msp@baylibre.com> (raw)
In-Reply-To: <20221206115728.1056014-1-msp@baylibre.com>

Instead of acknowledging every item of the fifo, only acknowledge the
last item read. This behavior is documented in the datasheet. The new
getindex will be the acknowledged item + 1.

Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
---
 drivers/net/can/m_can/m_can.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 5572a6b3b94c..56f07f2023dd 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -529,9 +529,6 @@ static int m_can_read_fifo(struct net_device *dev, u32 fgi)
 	}
 	stats->rx_packets++;
 
-	/* acknowledge rx fifo 0 */
-	m_can_write(cdev, M_CAN_RXF0A, fgi);
-
 	timestamp = FIELD_GET(RX_BUF_RXTS_MASK, fifo_header.dlc) << 16;
 
 	m_can_receive_skb(cdev, skb, timestamp);
@@ -552,8 +549,9 @@ static int m_can_do_rx_poll(struct net_device *dev, int quota)
 	u32 rxfs;
 	u32 rx_count;
 	u32 fgi;
+	int ack_fgi = -1;
 	int i;
-	int err;
+	int err = 0;
 
 	rxfs = m_can_read(cdev, M_CAN_RXF0S);
 	if (!(rxfs & RXFS_FFL_MASK)) {
@@ -567,13 +565,20 @@ static int m_can_do_rx_poll(struct net_device *dev, int quota)
 	for (i = 0; i < rx_count && quota > 0; ++i) {
 		err = m_can_read_fifo(dev, fgi);
 		if (err)
-			return err;
+			break;
 
 		quota--;
 		pkts++;
+		ack_fgi = fgi;
 		fgi = (++fgi >= cdev->mcfg[MRAM_RXF0].num ? 0 : fgi);
 	}
 
+	if (ack_fgi != -1)
+		m_can_write(cdev, M_CAN_RXF0A, ack_fgi);
+
+	if (err)
+		return err;
+
 	return pkts;
 }
 
-- 
2.38.1


  parent reply	other threads:[~2022-12-06 11:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 11:57 [PATCH v2 00/11] can: m_can: Optimizations for tcan and peripheral chips Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 01/11] can: m_can: Eliminate double read of TXFQS in tx_handler Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 02/11] can: m_can: Avoid reading irqstatus twice Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 03/11] can: m_can: Read register PSR only on error Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 04/11] can: m_can: Count TXE FIFO getidx in the driver Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 05/11] can: m_can: Count read getindex " Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 06/11] can: m_can: Batch acknowledge transmit events Markus Schneider-Pargmann
2022-12-06 11:57 ` Markus Schneider-Pargmann [this message]
2022-12-06 11:57 ` [PATCH v2 08/11] can: tcan4x5x: Remove invalid write in clear_interrupts Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 09/11] can: tcan4x5x: Fix use of register error status mask Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 10/11] can: tcan4x5x: Fix register range of first two blocks Markus Schneider-Pargmann
2022-12-06 11:57 ` [PATCH v2 11/11] can: tcan4x5x: Specify separate read/write ranges Markus Schneider-Pargmann
2022-12-06 16:20   ` Marc Kleine-Budde
2022-12-12 10:54     ` Marc Kleine-Budde
2022-12-13 17:10       ` Markus Schneider-Pargmann
2022-12-13 19:10         ` Markus Schneider-Pargmann
2022-12-13 19:13           ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221206115728.1056014-8-msp@baylibre.com \
    --to=msp@baylibre.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=rcsekar@samsung.com \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox