From: Pavel Pisa <pisa@cmp.felk.cvut.cz>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ondrej Ille <ondrej.ille@gmail.com>,
Wolfgang Grandegger <wg@grandegger.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 06/19] can: ctucanfd: Convert to platform remove callback returning void
Date: Sun, 14 May 2023 15:50:59 +0200 [thread overview]
Message-ID: <202305141550.59128.pisa@cmp.felk.cvut.cz> (raw)
In-Reply-To: <20230512212725.143824-7-u.kleine-koenig@pengutronix.de>
On Friday 12 of May 2023 23:27:12 Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is ignored (apart from
> emitting a warning) and this typically results in resource leaks. To
> improve here there is a quest to make the remove callback return void. In
> the first step of this quest all drivers are converted to .remove_new()
> which already returns void. Eventually after all drivers are converted,
> .remove_new() is renamed to .remove().
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>
Thanks for maintenace, Pavel.
next prev parent reply other threads:[~2023-05-14 14:00 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 21:27 [PATCH net-next 00/19] can: Convert to platform remove callback returning void Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 01/19] can: at91_can: " Uwe Kleine-König
2023-05-15 6:48 ` Claudiu.Beznea
2023-05-12 21:27 ` [PATCH 02/19] can: bxcan: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 03/19] can: c_can: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 04/19] can: cc770_isa: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 05/19] can: cc770_platform: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 06/19] can: ctucanfd: " Uwe Kleine-König
2023-05-14 13:50 ` Pavel Pisa [this message]
2023-05-12 21:27 ` [PATCH 07/19] can: flexcan: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 08/19] can: grcan: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 09/19] can: ifi_canfd: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 10/19] can: janz-ican3: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 11/19] can: m_can: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 12/19] can: mscan/mpc5xxx_can.c -- " Uwe Kleine-König
2023-05-12 21:37 ` Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 13/19] can: rcar: " Uwe Kleine-König
2023-05-15 7:53 ` Geert Uytterhoeven
2023-05-12 21:27 ` [PATCH 14/19] can: sja1000_isa: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 15/19] can: sja1000_platform: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 16/19] can: softing: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 17/19] can: sun4i_can: " Uwe Kleine-König
2023-05-13 6:36 ` Jernej Škrabec
2023-05-14 17:05 ` Gerhard Bertelsmann
2023-05-12 21:27 ` [PATCH 18/19] can: ti_hecc: " Uwe Kleine-König
2023-05-12 21:27 ` [PATCH 19/19] can: xilinx: " Uwe Kleine-König
2023-05-16 7:31 ` [PATCH net-next 00/19] can: " Simon Horman
2023-05-16 8:45 ` Simon Horman
2023-05-16 8:54 ` Marc Kleine-Budde
2023-05-16 8:56 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305141550.59128.pisa@cmp.felk.cvut.cz \
--to=pisa@cmp.felk.cvut.cz \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=ondrej.ille@gmail.com \
--cc=pabeni@redhat.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox