From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7027EB64D7 for ; Wed, 21 Jun 2023 18:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229820AbjFUSAq (ORCPT ); Wed, 21 Jun 2023 14:00:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjFUSAq (ORCPT ); Wed, 21 Jun 2023 14:00:46 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 546891738; Wed, 21 Jun 2023 11:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687370442; x=1718906442; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1o7c22ogjix8/UMzT1uyJ+SlopylsPQrSnXMByN0VwI=; b=jfmhTXVVRYJSuF8vQVk/5ZQdRlLTEWZ9Rp2gSu1u0mbb4vdXGoHcJeFr +NwbB4FMhtRIHmsYUiU9uYfK4DiZoxK6R1TEFYC2P8gSOwqqjUNc0VpmZ bheQITChEb6T+fHeIIvxShTaa8o99LCT5HFqu4/4SyAwsw2x+Zyqvn4ez 4hlq0Gva+aBsYlr/qvb/t+dut0Y6b64IIgMIjkyAROx4lpvbZhQRWxKUx Xpuv9Mb54zwHz/xoPRgqhCQx+332EwmaLGtRim3ZTauzLUWx4b7LKNOWk Xcj861GLq4Qd5NCjiJKOcaXO1KKZCZfxkRo1RL1zIgoOt4jadzrw8/I1q A==; X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="359124988" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="359124988" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2023 11:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10748"; a="717757059" X-IronPort-AV: E=Sophos;i="6.00,261,1681196400"; d="scan'208";a="717757059" Received: from lkp-server01.sh.intel.com (HELO 783282924a45) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 21 Jun 2023 11:00:15 -0700 Received: from kbuild by 783282924a45 with local (Exim 4.96) (envelope-from ) id 1qC27q-00070F-0y; Wed, 21 Jun 2023 18:00:14 +0000 Date: Thu, 22 Jun 2023 02:00:04 +0800 From: kernel test robot To: Markus Schneider-Pargmann , Marc Kleine-Budde , Chandrasekar Ramakrishnan , Wolfgang Grandegger Cc: oe-kbuild-all@lists.linux.dev, Vincent MAILHOL , Simon Horman , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julien Panis , Markus Schneider-Pargmann Subject: Re: [PATCH v4 04/12] can: m_can: Add rx coalescing ethtool support Message-ID: <202306220129.pZuUUlrk-lkp@intel.com> References: <20230621092350.3130866-5-msp@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621092350.3130866-5-msp@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi Markus, kernel test robot noticed the following build warnings: [auto build test WARNING on ac9a78681b921877518763ba0e89202254349d1b] url: https://github.com/intel-lab-lkp/linux/commits/Markus-Schneider-Pargmann/can-m_can-Write-transmit-header-and-data-in-one-transaction/20230621-173848 base: ac9a78681b921877518763ba0e89202254349d1b patch link: https://lore.kernel.org/r/20230621092350.3130866-5-msp%40baylibre.com patch subject: [PATCH v4 04/12] can: m_can: Add rx coalescing ethtool support config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230622/202306220129.pZuUUlrk-lkp@intel.com/config) compiler: sparc64-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230622/202306220129.pZuUUlrk-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202306220129.pZuUUlrk-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/net/can/m_can/m_can.c: In function 'm_can_tx_handler': drivers/net/can/m_can/m_can.c:1697:27: warning: unused variable 'fifo_header' [-Wunused-variable] 1697 | struct id_and_dlc fifo_header; | ^~~~~~~~~~~ drivers/net/can/m_can/m_can.c: In function 'm_can_set_coalesce': >> drivers/net/can/m_can/m_can.c:1978:45: warning: suggest parentheses around comparison in operand of '!=' [-Wparentheses] 1978 | if (ec->rx_max_coalesced_frames_irq == 0 != ec->rx_coalesce_usecs_irq == 0) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~ drivers/net/can/m_can/m_can.c:1978:50: warning: suggest parentheses around comparison in operand of '==' [-Wparentheses] 1978 | if (ec->rx_max_coalesced_frames_irq == 0 != ec->rx_coalesce_usecs_irq == 0) { | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ vim +1978 drivers/net/can/m_can/m_can.c 1959 1960 static int m_can_set_coalesce(struct net_device *dev, 1961 struct ethtool_coalesce *ec, 1962 struct kernel_ethtool_coalesce *kec, 1963 struct netlink_ext_ack *ext_ack) 1964 { 1965 struct m_can_classdev *cdev = netdev_priv(dev); 1966 1967 if (cdev->can.state != CAN_STATE_STOPPED) { 1968 netdev_err(dev, "Device is in use, please shut it down first\n"); 1969 return -EBUSY; 1970 } 1971 1972 if (ec->rx_max_coalesced_frames_irq > cdev->mcfg[MRAM_RXF0].num) { 1973 netdev_err(dev, "rx-frames-irq %u greater than the RX FIFO %u\n", 1974 ec->rx_max_coalesced_frames_irq, 1975 cdev->mcfg[MRAM_RXF0].num); 1976 return -EINVAL; 1977 } > 1978 if (ec->rx_max_coalesced_frames_irq == 0 != ec->rx_coalesce_usecs_irq == 0) { 1979 netdev_err(dev, "rx-frames-irq and rx-usecs-irq can only be set together\n"); 1980 return -EINVAL; 1981 } 1982 1983 cdev->rx_max_coalesced_frames_irq = ec->rx_max_coalesced_frames_irq; 1984 cdev->rx_coalesce_usecs_irq = ec->rx_coalesce_usecs_irq; 1985 1986 return 0; 1987 } 1988 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki