From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B05BEE748F3 for ; Sun, 1 Oct 2023 17:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235161AbjJARN0 (ORCPT ); Sun, 1 Oct 2023 13:13:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235159AbjJARN0 (ORCPT ); Sun, 1 Oct 2023 13:13:26 -0400 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3575683; Sun, 1 Oct 2023 10:13:23 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 247CE60006; Sun, 1 Oct 2023 17:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1696180400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MqDlq23BdivJmb4Esbr99inDuNaw3gvSKLPwMkXV73I=; b=IrqthlLpqqDLnIbT9dzYKmTcnXLVXR/CwZW2pn8440viRostXbGF5WodVKlOwFQcarnL5k JdSxfd/XAMbpttOxh9/2tqEi6KtrLq6DGQpFykyJGMGhaBCz1nmiwRAElvE8jJx9U8Noht wyCoyKlCVP9uODP6RYOIdOVjl5tW7u2FzVdnLh50tb96IOXcEM4pDDl+JWpOhiYdYt3sOr x8CeS9N7+0mgVMywqPHbABoKWNGzaQRMdYdgGPMIeTsajRyQodcMMeecqFXhqwIQ3VbjtP 5v3hFrDxHIuc7llT+Guz0FEeEcWf2dY+KD+sA7qpNJI1bPnBxE4QqzBoUA4n4w== Date: Sun, 1 Oct 2023 19:13:16 +0200 From: Miquel Raynal To: Simon Horman Cc: Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , netdev@vger.kernel.org, linux-can@vger.kernel.org, =?UTF-8?B?SsOpcsOpbWll?= Dautheribes , Thomas Petazzoni , sylvain.girard@se.com, pascal.eberhard@se.com Subject: Re: [PATCH net-next] can: sja1000: Fix comment Message-ID: <20231001191316.466d0482@xps-13> In-Reply-To: <20230928123556.GH24230@kernel.org> References: <20230922155130.592187-1-miquel.raynal@bootlin.com> <20230928123556.GH24230@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org Hi Simon, horms@kernel.org wrote on Thu, 28 Sep 2023 14:35:56 +0200: > On Fri, Sep 22, 2023 at 05:51:30PM +0200, Miquel Raynal wrote: > > There is likely a copy-paste error here, as the exact same comment > > appears below in this function, one time calling set_reset_mode(), the > > other set_normal_mode(). > >=20 > > Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller") =20 >=20 > I'm not sure this warrants a fixes tag, which implies backporting, > but in any case the tag is correct. My understanding is that "Fixes" does not imply backporting, whereas "Cc: stable@vger.kernel.org" actually does. In practice, stable maintainers are using magic scripts which, it's true, often select patches which contain a Fixes tag, but that's more a consequence of people not Cc'ing stable when it's relevant :) > > Signed-off-by: Miquel Raynal =20 >=20 > The above comment notwithstanding, this seems correct to me. >=20 > Reviewed-by: Simon Horman Thanks for the review, Miqu=C3=A8l