From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2000B125B8; Fri, 8 Dec 2023 19:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="q0jHp+lr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 761F0C433C8; Fri, 8 Dec 2023 19:26:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702063576; bh=HmU9LMehAw9DeUV8uCa+TBiQ2MWNpmsc6U26C4PITlc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q0jHp+lrFGrxQQ5fEQ0yYQ4fe+W9y4ZBbiIbF5Fm6XNgANu/LLyFCi7GKBQlImOK1 zQ5FX411R3rVVBA++4kibVU+Ry2zU52I2LBtZFygSsz/2u+K0JWWcT+JXE2mM3eQa5 aMaNS4Jl0owLVOpVhyAh5+5NDmpWsy7qBKYlhrzdxgnBQPmrOGOcSpTvp+Y7TY454O WxcxrL2t/YvNsOiGxmkthRidpOyy3nyHyi8BYNeIuulbHZ7ApFNEULZz6fP97KusN/ TGdMkp+mrZygRRBt5EpnO283TOKGmC2DO1viuGwbfey/SpXfK9+mVbEe3SEJjdhIMr WKX33bNQlujUg== Date: Fri, 8 Dec 2023 19:26:10 +0000 From: Conor Dooley To: Emil Renner Berthing Cc: linux-riscv@lists.infradead.org, Conor Dooley , Daire McNamara , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Michael Turquette , Stephen Boyd , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH RESEND v1 1/7] dt-bindings: clock: mpfs: add more MSSPLL output definitions Message-ID: <20231208-cauterize-hacker-f63dddf39af0@spud> References: <20231208-reenter-ajar-b6223e5134b3@spud> <20231208-unripe-maximum-fc77f4967561@spud> Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="keUDLXTW9SCPY39T" Content-Disposition: inline In-Reply-To: --keUDLXTW9SCPY39T Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 08, 2023 at 09:40:00AM -0800, Emil Renner Berthing wrote: > Conor Dooley wrote: > > From: Conor Dooley > > > > There are 3 undocumented outputs of the MSSPLL that are used for the CAN > > bus, "user crypto" module and eMMC. Add their clock IDs so that they can > > be hooked up in DT. > > > > Signed-off-by: Conor Dooley > > --- > > include/dt-bindings/clock/microchip,mpfs-clock.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/dt-bindings/clock/microchip,mpfs-clock.h b/include= /dt-bindings/clock/microchip,mpfs-clock.h > > index 79775a5134ca..b52f19a2b480 100644 > > --- a/include/dt-bindings/clock/microchip,mpfs-clock.h > > +++ b/include/dt-bindings/clock/microchip,mpfs-clock.h > > @@ -44,6 +44,11 @@ > > > > #define CLK_RTCREF 33 > > #define CLK_MSSPLL 34 > > +#define CLK_MSSPLL0 34 >=20 > You add this new CLK_MSSPLL0 macro with the same value as CLK_MSSPLL, but > never seem to use it in this series. Did you mean to rename the CLK_MSSPLL > instances CLK_MSSPLL0? Yes, that was my intention. --keUDLXTW9SCPY39T Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZXNt0gAKCRB4tDGHoIJi 0mr/AQDAPWA0oJFGAgd3kwzO+18/rBTPVxEGkrO5J9+fukpyOAEAyrgQk4472IpW 41zAPoXiQ9UbdlNLIljJi2H7VMzCYAw= =YxhE -----END PGP SIGNATURE----- --keUDLXTW9SCPY39T--