From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DC57145B2D for ; Mon, 14 Oct 2024 13:53:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728914006; cv=none; b=X+RcwPMCa6vtc/PYk/NBV+vqqu4ok0oXL72ouVc7Y+gxyoLxtk+0P1VuqY+M1Lc191bDpMJBoaR6RNO7StosoKM7w4JsOnHRxP2ENuyIvTAjYr6Gp6w3qEGqVM3MAOgI9+zo9BJtPKJX3WZxdwkLBsksFMgrglN5qS+U+naQxHI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728914006; c=relaxed/simple; bh=wO1p7F8hTbe6EvNqBYXOiLlzfHpxDRcCcmzq1hS40nM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CGOU9/GOSBkx+Es2GEODo+keBKQSL6zhQnIW2ujthxVJcfJqCfrs0DXnqIunJ/09S5jWYumriR56hOfvODByIhXBxRvQNhC8HCegLp/KXZ4GN4VsI1zQupeeQIwv/JgNY9B0efi35q70ZaFt2nhDfsPqRKhXRZdAJ4NsxsY3jUg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com; spf=pass smtp.mailfrom=amarulasolutions.com; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b=H1GXdiwb; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amarulasolutions.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="H1GXdiwb" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-431126967d6so38305785e9.0 for ; Mon, 14 Oct 2024 06:53:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1728914003; x=1729518803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6TIk4NNoYSacsyCpliVko137LO9s6zdaj7BCOJzXy4w=; b=H1GXdiwbgGpQHRFul3DLuub7dC05K0wOqeadaORQ6IiTsfe3mvzi62Wq+p3qZ5htPn jr/49aC9t1bkjSBrv69Vl8kNXoQiwL1sfr+oZ0oz2abVZaiCvbKGfz/+cRN483X+yzlS +XJRkll3VCw6vcZ2VtioDircp96J6ncYtdLms= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728914003; x=1729518803; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6TIk4NNoYSacsyCpliVko137LO9s6zdaj7BCOJzXy4w=; b=MtASrd1W0c0Npc/c43/LY++jXpaaYlV8QmelC2JqBcZlwv/1u2XTgoc7EkpBbQKpMK U8anCU51MjxHTIASOidPwZ1t1y7QtaoEBEFyIfVx1vHe3WhJVNhks220tUsW9PHhspCS vrSoa4o8s43yCGtMKD8o5iKdmSwck1W2lDz4g0akd5m9J4vC7KyLjZNduts4XUEzIk6M fOq7SfpihoY/g0u73/Bc9do4gpkSdNPtoxQwMWckHro2rSNK/TQkGVr+HklfZuPmuJNL rmWH5/5dczpt8th29ip0YWIBwaTpwb9+2/Ktd4MLrhSleeoDbREmuofq3LAVCVbjVS0s LoRA== X-Forwarded-Encrypted: i=1; AJvYcCX+ISHcJ0ZNYZ9LquSxrSs6MrAZ742G0TRdfFXWj/lEDwgx5whFIcAKo2AfeC4ToqEUCnn3A7XiX8U=@vger.kernel.org X-Gm-Message-State: AOJu0Yza0CdKV6Hat2OECmr2CNiVR/qlpnhcvZgvLJ4C+macaQyCAJl8 CLGw9KDVDHmpCNnOnUWQ1iXWZ3W2Q6DWWBdiBPLJAXrYXj9hodf0L0yfr0NksLw= X-Google-Smtp-Source: AGHT+IFU8nMmMZvmAm92MZA8kiagzy2/gyT7Zuw/cdPJ3Tx8noMToQdFFFTMB/DFffOK7NOo+jLKdA== X-Received: by 2002:a5d:43c6:0:b0:37c:cf73:4bf7 with SMTP id ffacd0b85a97d-37d551fca59mr7838791f8f.34.1728914003327; Mon, 14 Oct 2024 06:53:23 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.amarulasolutions.com ([2.196.40.133]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d4b6cff9asm11404402f8f.48.2024.10.14.06.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 06:53:22 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com, Dario Binacchi , Bhupesh Sharma , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Marc Kleine-Budde , Paolo Abeni , Vincent Mailhol , linux-can@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH] can: c_can: fix {rx,tx}_errors statistics Date: Mon, 14 Oct 2024 15:53:13 +0200 Message-ID: <20241014135319.2009782-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The c_can_handle_bus_err() function was incorrectly incrementing only the receive error counter, even in cases of bit or acknowledgment errors that occur during transmission. The patch fixes the issue by incrementing the appropriate counter based on the type of error. Fixes: 881ff67ad450 ("can: c_can: Added support for Bosch C_CAN controller") Signed-off-by: Dario Binacchi --- drivers/net/can/c_can/c_can_main.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/c_can/c_can_main.c b/drivers/net/can/c_can/c_can_main.c index c63f7fc1e691..511615dc3341 100644 --- a/drivers/net/can/c_can/c_can_main.c +++ b/drivers/net/can/c_can/c_can_main.c @@ -1011,7 +1011,6 @@ static int c_can_handle_bus_err(struct net_device *dev, /* common for all type of bus errors */ priv->can.can_stats.bus_error++; - stats->rx_errors++; /* propagate the error condition to the CAN stack */ skb = alloc_can_err_skb(dev, &cf); @@ -1027,26 +1026,32 @@ static int c_can_handle_bus_err(struct net_device *dev, case LEC_STUFF_ERROR: netdev_dbg(dev, "stuff error\n"); cf->data[2] |= CAN_ERR_PROT_STUFF; + stats->rx_errors++; break; case LEC_FORM_ERROR: netdev_dbg(dev, "form error\n"); cf->data[2] |= CAN_ERR_PROT_FORM; + stats->rx_errors++; break; case LEC_ACK_ERROR: netdev_dbg(dev, "ack error\n"); cf->data[3] = CAN_ERR_PROT_LOC_ACK; + stats->tx_errors++; break; case LEC_BIT1_ERROR: netdev_dbg(dev, "bit1 error\n"); cf->data[2] |= CAN_ERR_PROT_BIT1; + stats->tx_errors++; break; case LEC_BIT0_ERROR: netdev_dbg(dev, "bit0 error\n"); cf->data[2] |= CAN_ERR_PROT_BIT0; + stats->tx_errors++; break; case LEC_CRC_ERROR: netdev_dbg(dev, "CRC error\n"); cf->data[3] = CAN_ERR_PROT_LOC_CRC_SEQ; + stats->rx_errors++; break; default: break; -- 2.43.0