From: Antonios Salios <antonios@mwa.re>
To: rcsekar@samsung.com
Cc: mkl@pengutronix.de, mailhol.vincent@wanadoo.fr,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
lukas@mwa.re, jan@mwa.re, Antonios Salios <antonios@mwa.re>
Subject: [PATCH] can: m_can: initialize spin lock on device probe
Date: Thu, 24 Apr 2025 14:52:20 +0200 [thread overview]
Message-ID: <20250424125219.47345-2-antonios@mwa.re> (raw)
The spin lock tx_handling_spinlock in struct m_can_classdev is not being
initialized. This leads to bug complaints from the kernel, eg. when
trying to send CAN frames with cansend from can-utils.
This patch fixes that by initializing the spin lock in the corresponding
device probe functions.
Signed-off-by: Antonios Salios <antonios@mwa.re>
---
drivers/net/can/m_can/m_can_pci.c | 1 +
drivers/net/can/m_can/m_can_platform.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/can/m_can/m_can_pci.c b/drivers/net/can/m_can/m_can_pci.c
index 9ad7419f8..06243cd43 100644
--- a/drivers/net/can/m_can/m_can_pci.c
+++ b/drivers/net/can/m_can/m_can_pci.c
@@ -143,6 +143,7 @@ static int m_can_pci_probe(struct pci_dev *pci, const struct pci_device_id *id)
pm_runtime_use_autosuspend(dev);
pm_runtime_put_noidle(dev);
pm_runtime_allow(dev);
+ spin_lock_init(&mcan_class->tx_handling_spinlock);
return 0;
diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
index b832566ef..c09c61d25 100644
--- a/drivers/net/can/m_can/m_can_platform.c
+++ b/drivers/net/can/m_can/m_can_platform.c
@@ -154,6 +154,7 @@ static int m_can_plat_probe(struct platform_device *pdev)
ret = m_can_class_register(mcan_class);
if (ret)
goto out_runtime_disable;
+ spin_lock_init(&mcan_class->tx_handling_spinlock);
return ret;
--
2.49.0
next reply other threads:[~2025-04-24 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 12:52 Antonios Salios [this message]
2025-04-24 13:11 ` [PATCH] can: m_can: initialize spin lock on device probe Marc Kleine-Budde
2025-04-24 15:23 ` Vincent Mailhol
2025-04-25 6:34 ` Antonios Salios
2025-04-25 7:18 ` Vincent Mailhol
2025-04-25 9:18 ` Antonios Salios
2025-04-25 9:36 ` Vincent Mailhol
2025-04-25 8:15 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424125219.47345-2-antonios@mwa.re \
--to=antonios@mwa.re \
--cc=jan@mwa.re \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@mwa.re \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=rcsekar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox