Re: [PATCH] can: gw: fix RCU/BH usage in cgw_create_job()

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 2025-04-28 22:11:48 [+0200], Oliver Hartkopp wrote:
> Hi Sebastian,
Hi Oliver,

> thanks for your interesting work!
> 
> I have one comment/question inline ...
> 
> On 17.04.25 16:41, Sebastian Andrzej Siewior wrote:
> 
> >   	err = cgw_register_filter(net, gwj);
> > -	if (!err)
> > +	if (!err) {
> >   		hlist_add_head_rcu(&gwj->list, &net->can.cgw_list);
> > +		mod = NULL;
> 
> I assume this assignment prevents to kfree() the assigned mod data some
> lines below, right?

Yes, that is the reason but I think I can do better.

> If so there should be a comment why this assignment was made.
> 
> > +	}
> >   out:
> >   	if (err)
> >   		kmem_cache_free(cgw_cache, gwj);
> > -
> > +out_free_cf:
> > +	kfree(mod);  <<<<<<<<<< HERE <<<<<<<<<<
> >   	return err;
> >   }
> 
> You can also add my
> 
> Tested-by: Oliver Hartkopp <socketcan@hartkopp.net>
> 
> Many thanks,
> Oliver

Sebastian