* [PATCH] can: janz-ican3: use sysfs_emit() in fwinfo_show()
@ 2025-07-12 13:36 Khaled Elnaggar
2025-07-15 9:45 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Khaled Elnaggar @ 2025-07-12 13:36 UTC (permalink / raw)
To: mkl, mailhol.vincent
Cc: Khaled Elnaggar, linux-kernel-mentees, shuah, linux-can,
linux-kernel
As recommended in Documentation/filesystems/sysfs.rst, show() callbacks
should use sysfs_emit() or sysfs_emit_at() to format values returned to
userspace. Replace scnprintf() with sysfs_emit() in fwinfo_show().
Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
---
drivers/net/can/janz-ican3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/janz-ican3.c b/drivers/net/can/janz-ican3.c
index 60c7b83b4539..bfa5cbe88017 100644
--- a/drivers/net/can/janz-ican3.c
+++ b/drivers/net/can/janz-ican3.c
@@ -1867,7 +1867,7 @@ static ssize_t fwinfo_show(struct device *dev,
{
struct ican3_dev *mod = netdev_priv(to_net_dev(dev));
- return scnprintf(buf, PAGE_SIZE, "%s\n", mod->fwinfo);
+ return sysfs_emit(buf, "%s\n", mod->fwinfo);
}
static DEVICE_ATTR_RW(termination);
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] can: janz-ican3: use sysfs_emit() in fwinfo_show()
2025-07-12 13:36 [PATCH] can: janz-ican3: use sysfs_emit() in fwinfo_show() Khaled Elnaggar
@ 2025-07-15 9:45 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2025-07-15 9:45 UTC (permalink / raw)
To: Khaled Elnaggar
Cc: mailhol.vincent, linux-kernel-mentees, shuah, linux-can,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
On 12.07.2025 16:36:07, Khaled Elnaggar wrote:
> As recommended in Documentation/filesystems/sysfs.rst, show() callbacks
> should use sysfs_emit() or sysfs_emit_at() to format values returned to
> userspace. Replace scnprintf() with sysfs_emit() in fwinfo_show().
>
> Signed-off-by: Khaled Elnaggar <khaledelnaggarlinux@gmail.com>
Applied to linux-can-next.
Thanks,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-15 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-12 13:36 [PATCH] can: janz-ican3: use sysfs_emit() in fwinfo_show() Khaled Elnaggar
2025-07-15 9:45 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).