* [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104
@ 2025-07-20 0:02 Randy Dunlap
2025-07-20 4:50 ` Vincent Mailhol
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2025-07-20 0:02 UTC (permalink / raw)
To: netdev
Cc: Randy Dunlap, Andre B. Oliveira, linux-can, Marc Kleine-Budde,
Vincent Mailhol, Andrew Lunn, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Add a dependency on PC104 to limit (restrict) this driver kconfig
prompt to kernel configs that have PC104 set.
Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Andre B. Oliveira <anbadeol@gmail.com>
Cc: linux-can@vger.kernel.org
Cc: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
---
drivers/net/can/sja1000/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig
+++ linux-next-20250718/drivers/net/can/sja1000/Kconfig
@@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
config CAN_TSCAN1
tristate "TS-CAN1 PC104 boards"
- depends on ISA
+ depends on ISA && PC104
help
This driver is for Technologic Systems' TSCAN-1 PC104 boards.
https://www.embeddedts.com/products/TS-CAN1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104
2025-07-20 0:02 [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104 Randy Dunlap
@ 2025-07-20 4:50 ` Vincent Mailhol
2025-07-20 19:22 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Vincent Mailhol @ 2025-07-20 4:50 UTC (permalink / raw)
To: Randy Dunlap
Cc: Andre B. Oliveira, linux-can, Marc Kleine-Budde, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On 20/07/2025 at 09:02, Randy Dunlap wrote:
> Add a dependency on PC104 to limit (restrict) this driver kconfig
> prompt to kernel configs that have PC104 set.
>
> Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Andre B. Oliveira <anbadeol@gmail.com>
> Cc: linux-can@vger.kernel.org
> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> ---
> drivers/net/can/sja1000/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig
> +++ linux-next-20250718/drivers/net/can/sja1000/Kconfig
> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>
> config CAN_TSCAN1
> tristate "TS-CAN1 PC104 boards"
> - depends on ISA
> + depends on ISA && PC104
A bit unrelated but ISA depends on X86_32 so I would suggest to add a
COMPILE_TEST so that people can still do test builds on x86_64.
depends on (ISA && PC104) || COMPILE_TEST
Yours sincerely,
Vincent Mailhol
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104
2025-07-20 4:50 ` Vincent Mailhol
@ 2025-07-20 19:22 ` Randy Dunlap
2025-07-21 9:29 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2025-07-20 19:22 UTC (permalink / raw)
To: Vincent Mailhol
Cc: Andre B. Oliveira, linux-can, Marc Kleine-Budde, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On 7/19/25 9:50 PM, Vincent Mailhol wrote:
> On 20/07/2025 at 09:02, Randy Dunlap wrote:
>> Add a dependency on PC104 to limit (restrict) this driver kconfig
>> prompt to kernel configs that have PC104 set.
>>
>> Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Andre B. Oliveira <anbadeol@gmail.com>
>> Cc: linux-can@vger.kernel.org
>> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
>> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
>> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
>> Cc: "David S. Miller" <davem@davemloft.net>
>> Cc: Eric Dumazet <edumazet@google.com>
>> Cc: Jakub Kicinski <kuba@kernel.org>
>> Cc: Paolo Abeni <pabeni@redhat.com>
>> ---
>> drivers/net/can/sja1000/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig
>> +++ linux-next-20250718/drivers/net/can/sja1000/Kconfig
>> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
>>
>> config CAN_TSCAN1
>> tristate "TS-CAN1 PC104 boards"
>> - depends on ISA
>> + depends on ISA && PC104
>
> A bit unrelated but ISA depends on X86_32 so I would suggest to add a
> COMPILE_TEST so that people can still do test builds on x86_64.
>
> depends on (ISA && PC104) || COMPILE_TEST
Sure, I can change that and see if any robots find problems with it.
I did a few x86_64 builds with PC104 not set, COMPILE_TEST set,
and CAN_TSCAN1 = y / m. I didn't encounter any problems.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104
2025-07-20 19:22 ` Randy Dunlap
@ 2025-07-21 9:29 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2025-07-21 9:29 UTC (permalink / raw)
To: Randy Dunlap
Cc: Vincent Mailhol, Andre B. Oliveira, linux-can, Marc Kleine-Budde,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev
On Sun, Jul 20, 2025 at 12:22:56PM -0700, Randy Dunlap wrote:
>
>
> On 7/19/25 9:50 PM, Vincent Mailhol wrote:
> > On 20/07/2025 at 09:02, Randy Dunlap wrote:
> >> Add a dependency on PC104 to limit (restrict) this driver kconfig
> >> prompt to kernel configs that have PC104 set.
> >>
> >> Fixes: 2d3359f8b9e6 ("can: tscan1: add driver for TS-CAN1 boards")
> >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> >> Cc: Andre B. Oliveira <anbadeol@gmail.com>
> >> Cc: linux-can@vger.kernel.org
> >> Cc: Marc Kleine-Budde <mkl@pengutronix.de>
> >> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> >> Cc: Andrew Lunn <andrew+netdev@lunn.ch>
> >> Cc: "David S. Miller" <davem@davemloft.net>
> >> Cc: Eric Dumazet <edumazet@google.com>
> >> Cc: Jakub Kicinski <kuba@kernel.org>
> >> Cc: Paolo Abeni <pabeni@redhat.com>
> >> ---
> >> drivers/net/can/sja1000/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- linux-next-20250718.orig/drivers/net/can/sja1000/Kconfig
> >> +++ linux-next-20250718/drivers/net/can/sja1000/Kconfig
> >> @@ -105,7 +105,7 @@ config CAN_SJA1000_PLATFORM
> >>
> >> config CAN_TSCAN1
> >> tristate "TS-CAN1 PC104 boards"
> >> - depends on ISA
> >> + depends on ISA && PC104
> >
> > A bit unrelated but ISA depends on X86_32 so I would suggest to add a
> > COMPILE_TEST so that people can still do test builds on x86_64.
> >
> > depends on (ISA && PC104) || COMPILE_TEST
>
> Sure, I can change that and see if any robots find problems with it.
>
> I did a few x86_64 builds with PC104 not set, COMPILE_TEST set,
> and CAN_TSCAN1 = y / m. I didn't encounter any problems.
Thanks.
FWIIW, I agree that extending build coverage using COMPILE_TEST is a good idea.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-21 9:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-20 0:02 [PATCH] can: tscan1: CAN_TSCAN1 can depend on PC104 Randy Dunlap
2025-07-20 4:50 ` Vincent Mailhol
2025-07-20 19:22 ` Randy Dunlap
2025-07-21 9:29 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).