From: Jimmy Assarsson <extja@kvaser.com>
To: linux-can@vger.kernel.org
Cc: Jimmy Assarsson <jimmyassarsson@gmail.com>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Jimmy Assarsson <extja@kvaser.com>
Subject: [PATCH 3/9] can: kvaser_pciefd: Add intermediate variable for device struct in probe()
Date: Wed, 23 Jul 2025 10:32:30 +0200 [thread overview]
Message-ID: <20250723083236.9-4-extja@kvaser.com> (raw)
In-Reply-To: <20250723083236.9-1-extja@kvaser.com>
Add intermediate variable, for readability and to simplify future patches.
Signed-off-by: Jimmy Assarsson <extja@kvaser.com>
---
drivers/net/can/kvaser_pciefd.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
index c0bfeafb31f5..f2722473b865 100644
--- a/drivers/net/can/kvaser_pciefd.c
+++ b/drivers/net/can/kvaser_pciefd.c
@@ -1815,10 +1815,11 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev,
const struct pci_device_id *id)
{
int ret;
+ struct device *dev = &pdev->dev;
struct kvaser_pciefd *pcie;
const struct kvaser_pciefd_irq_mask *irq_mask;
- pcie = devm_kzalloc(&pdev->dev, sizeof(*pcie), GFP_KERNEL);
+ pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
if (!pcie)
return -ENOMEM;
@@ -1857,7 +1858,7 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev,
ret = pci_alloc_irq_vectors(pcie->pci, 1, 1, PCI_IRQ_INTX | PCI_IRQ_MSI);
if (ret < 0) {
- dev_err(&pcie->pci->dev, "Failed to allocate IRQ vectors.\n");
+ dev_err(dev, "Failed to allocate IRQ vectors.\n");
goto err_teardown_can_ctrls;
}
@@ -1870,7 +1871,7 @@ static int kvaser_pciefd_probe(struct pci_dev *pdev,
ret = request_irq(pcie->pci->irq, kvaser_pciefd_irq_handler,
IRQF_SHARED, KVASER_PCIEFD_DRV_NAME, pcie);
if (ret) {
- dev_err(&pcie->pci->dev, "Failed to request IRQ %d\n", pcie->pci->irq);
+ dev_err(dev, "Failed to request IRQ %d\n", pcie->pci->irq);
goto err_pci_free_irq_vectors;
}
iowrite32(KVASER_PCIEFD_SRB_IRQ_DPD0 | KVASER_PCIEFD_SRB_IRQ_DPD1,
--
2.49.0
next prev parent reply other threads:[~2025-07-23 8:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 8:32 [PATCH 0/9] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 1/9] can: kvaser_pciefd: Add support to control CAN LEDs on device Jimmy Assarsson
2025-07-23 12:09 ` Vincent Mailhol
2025-07-24 6:48 ` Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 2/9] can: kvaser_pciefd: Add support for ethtool set_phys_id() Jimmy Assarsson
2025-07-23 12:14 ` Vincent Mailhol
2025-07-23 8:32 ` Jimmy Assarsson [this message]
2025-07-23 8:32 ` [PATCH 4/9] can: kvaser_pciefd: Store the different firmware version components in a struct Jimmy Assarsson
2025-07-23 12:17 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 5/9] can: kvaser_pciefd: Store device channel index Jimmy Assarsson
2025-07-23 12:27 ` Vincent Mailhol
2025-07-24 7:05 ` Jimmy Assarsson
2025-07-24 7:48 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 6/9] can: kvaser_pciefd: Split driver into C-file and header-file Jimmy Assarsson
2025-07-23 8:32 ` [PATCH 7/9] can: kvaser_pciefd: Add devlink support Jimmy Assarsson
2025-07-23 12:31 ` Vincent Mailhol
2025-07-23 12:36 ` Marc Kleine-Budde
2025-07-23 12:46 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 8/9] can: kvaser_pciefd: Expose device firmware version via devlink info_get() Jimmy Assarsson
2025-07-23 12:33 ` Vincent Mailhol
2025-07-23 8:32 ` [PATCH 9/9] can: kvaser_pciefd: Add devlink port support Jimmy Assarsson
2025-07-23 12:37 ` [PATCH 0/9] can: kvaser_pciefd: Simplify identification of physical CAN interfaces Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250723083236.9-4-extja@kvaser.com \
--to=extja@kvaser.com \
--cc=jimmyassarsson@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox